Skip to content

Flovilmart/readme updates #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 9, 2018
Merged

Flovilmart/readme updates #588

merged 10 commits into from
Jul 9, 2018

Conversation

flovilmart
Copy link
Contributor

No description provided.

@flovilmart flovilmart mentioned this pull request Jun 26, 2018
@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #588 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          48       48           
  Lines        4039     4039           
  Branches      911      911           
=======================================
  Hits         3416     3416           
  Misses        623      623

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4bc1c...80e095b. Read the comment docs.

@flovilmart flovilmart requested review from acinader and dplewis July 4, 2018 15:58
@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

Can you update the Contribution.MD? With instruction for Unit test, integration test, jest etc. After your improvements with the parse-server repo I feel like I’ve been testing wrong here

@flovilmart
Copy link
Contributor Author

I'm not sure what need to be tested on this repo. Can you try to update it (the CONTRIBUTING) and let me review?

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

My English is really bad, plus I have my own method of testing this repo when I do PR’s. I’m curious on how you do it. Also it’s very outdated (Contribution.MD)

@flovilmart
Copy link
Contributor Author

plus I have my own method of testing this repo when I do PR’

How do you do it?

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

@montymxb parse-server-test script + multiple terminal windows on my Mac + there’s no fit for mocha so I have to comment out a lot of the test

@flovilmart
Copy link
Contributor Author

Oh wow! That’s not an optimized workflow at all :) do you use VSCODE?

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

Nope, I’ve seen developers use it over time but never picked it up. I’ve never once set a breakpoint using parse since I started contributing

@flovilmart
Copy link
Contributor Author

Haha :$ try the new contributing guide on parse-server then and tell me what’s broken :)

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

I got you, but updated it here also please 🙏

Bring it to 2018

@flovilmart
Copy link
Contributor Author

Hahaha i’ll Try :)

@flovilmart
Copy link
Contributor Author

@dplewis for the sake of consistency, I may update the tests from mocha to jasmine for the integration.

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

Speaking of outdated I know we want to deprecate this

https://github.com/parse-community/parse-server-example

When I get a new client I refer to this but it’s still using Node 4.3 instead of 8. (I should be using CLI I know) Can I have access to it?

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

@flovilmart npm run test + console.log is all I know

@dplewis
Copy link
Member

dplewis commented Jul 4, 2018

@flovilmart Thanks a lot, I was surprise there was no issues tab, we could catch regression if it was enabled.

parse-server-example

@flovilmart flovilmart merged commit 2640391 into master Jul 9, 2018
@flovilmart flovilmart deleted the flovilmart/readme-updates branch July 26, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants