-
-
Notifications
You must be signed in to change notification settings - Fork 597
Flovilmart/readme updates #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 48 48
Lines 4039 4039
Branches 911 911
=======================================
Hits 3416 3416
Misses 623 623 Continue to review full report at Codecov.
|
Can you update the Contribution.MD? With instruction for Unit test, integration test, jest etc. After your improvements with the parse-server repo I feel like I’ve been testing wrong here |
I'm not sure what need to be tested on this repo. Can you try to update it (the CONTRIBUTING) and let me review? |
My English is really bad, plus I have my own method of testing this repo when I do PR’s. I’m curious on how you do it. Also it’s very outdated (Contribution.MD) |
How do you do it? |
@montymxb parse-server-test script + multiple terminal windows on my Mac + there’s no fit for mocha so I have to comment out a lot of the test |
Oh wow! That’s not an optimized workflow at all :) do you use VSCODE? |
Nope, I’ve seen developers use it over time but never picked it up. I’ve never once set a breakpoint using parse since I started contributing |
Haha :$ try the new contributing guide on parse-server then and tell me what’s broken :) |
I got you, but updated it here also please 🙏 Bring it to 2018 |
Hahaha i’ll Try :) |
@dplewis for the sake of consistency, I may update the tests from mocha to jasmine for the integration. |
Speaking of outdated I know we want to deprecate this https://github.com/parse-community/parse-server-example When I get a new client I refer to this but it’s still using Node 4.3 instead of 8. (I should be using CLI I know) Can I have access to it? |
@flovilmart |
@flovilmart Thanks a lot, I was surprise there was no issues tab, we could catch regression if it was enabled. parse-server-example |
No description provided.