Skip to content

Greenkeeper/initial #587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Greenkeeper/initial #587

wants to merge 9 commits into from

Conversation

flovilmart
Copy link
Contributor

No description provided.

@dplewis
Copy link
Member

dplewis commented Jun 26, 2018

@flovilmart long overdue 🙏

@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files          48       48           
  Lines        4019     4019           
  Branches      906      906           
=======================================
  Hits         3399     3399           
  Misses        620      620

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8034f7...ce419f9. Read the comment docs.

@flovilmart
Copy link
Contributor Author

@dplewis not sure how to check if it's properly registered with greenkeeper :/

@dplewis
Copy link
Member

dplewis commented Jun 26, 2018

Are the gulp packages needed? As far as maintaining greenkeeper which packages are required

@flovilmart
Copy link
Contributor Author

All the pacakges are needed, the JS SDK builds are generated with gulp. This could be updated in the future I believe.

For greenkeeper, I'm not sure if it's running correctly as it was not setup properly before.

@flovilmart flovilmart closed this Jun 26, 2018
@dplewis
Copy link
Member

dplewis commented Jun 26, 2018

That’s true forgot about the build. I think greenkeeper is working because the bot is making commits on this PR. We’ll know soon

@flovilmart flovilmart deleted the greenkeeper/initial branch June 26, 2018 00:49
@flovilmart
Copy link
Contributor Author

Nah, those are the old initial commits: I'm reinit it, PR moved to #588

The initial commits are just the ones from the initial setup, which did not go through the 1st time :/ as per #445

@dplewis
Copy link
Member

dplewis commented Jun 26, 2018

Didn’t check the date on this lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants