Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Feb 3, 2021

Allows for users to change the testing server configurations during a test suite. Also allows for use to access current ParseServer instance. I referenced the helper.js from the Server repo.

  • Ensure only one beforeAll exists (in helper.js)
  • Add missing awaits to ParseACLTest.js and MasterKeyTest.js
  • Rename tests with duplicate names ArrayOperationTest.js
  • Fix flaky test in LiveQueryClientTest
  • Add reconfigureServer test cases
  • Add use strict to prevent global side effects

I'll run the CI a few times to make sure everything runs properly.

Needed for #1291

@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #1292 (3a6524f) into master (0c84f19) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1292   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           58        58           
  Lines         5650      5650           
  Branches      1273      1273           
=========================================
  Hits          5650      5650           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c84f19...146c8c1. Read the comment docs.

@dplewis dplewis requested review from davimacedo and mtrezza February 4, 2021 03:56
@dplewis
Copy link
Member Author

dplewis commented Feb 4, 2021

@mtrezza I turn on { random: true } in jasmine.json. I did this to find tests that depend on other tests, poorly written tests or test that don't teardown / clean up when they are done.

@mtrezza
Copy link
Member

mtrezza commented Feb 4, 2021

That is a good idea, we could also try to do that for Parse Server, if it doesn't go crazy. Since Parse Server will test with 6 environments after merging the PR, it should provide a good mix.

Do you plan to leave it on permanently?

Another thing, now that you're on it, IIRC there are duplicate tests where Parse Server tests something with the JS SDK and the JS SDK does an integration test with Parse Server. Such tests basically test the same thing just from different sides. Is there a way we can simplify this?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Wow, that is quite a clean-up!

@dplewis dplewis merged commit c8270a7 into master Feb 4, 2021
@dplewis dplewis deleted the reconfigure-server branch February 4, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants