-
-
Notifications
You must be signed in to change notification settings - Fork 600
Improve integration testing #1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1292 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 58 58
Lines 5650 5650
Branches 1273 1273
=========================================
Hits 5650 5650 Continue to review full report at Codecov.
|
|
@mtrezza I turn on |
|
That is a good idea, we could also try to do that for Parse Server, if it doesn't go crazy. Since Parse Server will test with 6 environments after merging the PR, it should provide a good mix. Do you plan to leave it on permanently? Another thing, now that you're on it, IIRC there are duplicate tests where Parse Server tests something with the JS SDK and the JS SDK does an integration test with Parse Server. Such tests basically test the same thing just from different sides. Is there a way we can simplify this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 Wow, that is quite a clean-up!
Allows for users to change the testing server configurations during a test suite. Also allows for use to access current ParseServer instance. I referenced the helper.js from the Server repo.
use strictto prevent global side effectsI'll run the CI a few times to make sure everything runs properly.
Needed for #1291