Implement go_router and update colors everywhere #16

erskingardner · 2025-05-20T16:10:43Z

Summary by CodeRabbit

New Features
- Introduced advanced routing using go_router with Riverpod for state management, enabling seamless navigation and authentication flow.
- Added authentication state provider for login/logout functionality.
- Centralized route constants and navigation helpers for easier navigation.
- Enhanced documentation for AI-powered CLI tools.
- Added comprehensive Flutter UI for onboarding, authentication, chat, and contact list screens.
Style
- Updated the entire app's color palette to a new "glitch" theme, affecting all UI components for a refreshed look.
- Improved code formatting and consistency across UI widgets.
Refactor
- Migrated navigation logic from Navigator to go_router throughout authentication and chat screens.
- Refactored routing setup to use provider-based configuration.
- Updated main app initialization to leverage new routing and theming.
Chores
- Integrated CocoaPods support into the macOS project for dependency management.

coderabbitai · 2025-05-20T16:10:51Z

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a comprehensive refactor of navigation and theming in a Flutter messaging app. The routing system is migrated to use go_router with Riverpod for state management, centralizing route definitions and navigation helpers. The color palette is standardized with a new "glitch" theme. Numerous UI components are updated to use the new navigation and color scheme, while authentication and routing logic are now provider-driven. Additional project configuration changes support CocoaPods integration for macOS.

Changes

File(s) / Group	Change Summary
`.context/01_rust_api.md`	Simplified `WhitenoiseState` struct and commented out multi-account support fields and methods.
`.cursor/rules/vibe-tools.mdc`	Added global rule file with detailed documentation for `vibe-tools` CLI.
`.repomix-plan-filtered.txt`	Added packed representation of the Flutter project, including routing, authentication, chat UI, and navigation flows.
`local-research/go_router_implementation_plan.md`	Added detailed plan for integrating `go_router` with Riverpod, including route structure, helpers, and best practices.
`lib/config/providers/auth_provider.dart`	Introduced `AuthState` class and `authProvider` for authentication state management.
`lib/main.dart`	Converted `MyApp` to `ConsumerWidget`, updated to use `routerProvider`, and changed theme color.
`lib/routing/router.dart`	Removed static router configuration file.
`lib/routing/router_provider.dart`	Added Riverpod-based `routerProvider` with authentication-aware routing and redirection.
`lib/routing/routes.dart`	Added navigation helper methods and imports for context-based routing.
`lib/shared/custom_button.dart`, `lib/shared/custom_textfield.dart`, `lib/ui/core/ui/custom_textfield.dart`	Updated color scheme to use new glitch palette; reformatted style and borders.
`lib/ui/core/themes/colors.dart`	Replaced old color constants with structured glitch palette and new color schemes.
`lib/ui/auth_flow/welcome_screen.dart`, `lib/ui/auth_flow/info_screen.dart`, `lib/ui/auth_flow/create_profile_screen.dart`, `lib/ui/auth_flow/key_created_screen.dart`, `lib/ui/auth_flow/logged_screen.dart`, `lib/ui/auth_flow/login_screen.dart`	Migrated navigation from `Navigator` to `go_router` and centralized route helpers; updated UI colors and text styling.
`lib/ui/chat/chat_screen.dart`, `lib/ui/chat/groupchat_screen.dart`	Updated navigation to use `go_router`, refactored formatting, and applied glitch color scheme.
`lib/ui/chat/widgets/`, `lib/ui/contact_list/widgets/`	Updated color constants, reformatted widget constructors, and improved style consistency.
`lib/ui/contact_list/chat_invitation_sheet.dart`, `lib/ui/contact_list/start_chat_bottom_sheet.dart`, `lib/ui/contact_list/group_chat_details_sheet.dart`, `lib/ui/contact_list/new_chat_bottom_sheet.dart`	Reformatted builder functions, updated color constants, and improved style.
`lib/ui/contact_list/chat_list_screen.dart`	Added imports for `go_router` and route definitions.
`macos/Runner.xcodeproj/project.pbxproj`, `macos/Runner.xcworkspace/contents.xcworkspacedata`	Integrated CocoaPods frameworks/configs into macOS project and workspace.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant App (Flutter)
  participant RouterProvider (Riverpod)
  participant AuthProvider
  participant GoRouter

  User->>App (Flutter): Launches app
  App (Flutter)->>RouterProvider: Requests router instance
  RouterProvider->>AuthProvider: Checks authentication state
  AuthProvider-->>RouterProvider: Returns isAuthenticated
  RouterProvider->>GoRouter: Configures routes and redirects
  GoRouter-->>App (Flutter): Provides navigation structure

  User->>App (Flutter): Interacts with login/onboarding
  App (Flutter)->>AuthProvider: Calls login()
  AuthProvider-->>RouterProvider: Notifies state change
  RouterProvider->>GoRouter: Triggers redirect
  GoRouter-->>App (Flutter): Navigates to contacts/chat screen

Poem

A new route hops in, the glitch theme shines bright,
Riverpod guides us through day and through night.
Buttons and borders, now stylish and neat,
Chats and contacts with colors replete.
CocoaPods join the warren, dependencies in tow,
The White Noise app’s ready—let’s give it a go!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1889c03 and 846391f.

📒 Files selected for processing (4)

.cursor/rules/vibe-tools.mdc (1 hunks)
lib/config/providers/auth_provider.dart (1 hunks)
lib/ui/chat/widgets/chat_input.dart (17 hunks)
local-research/go_router_implementation_plan.md (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 6

🧹 Nitpick comments (15)

macos/Runner.xcodeproj/project.pbxproj (2)
325-342: Hard-coded file-list paths are fragile

The embed-phase script assumes ${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks-${CONFIGURATION}-input-files.xcfilelist.
If the Podfile target name changes or a user employs custom build configurations (Staging, AdHoc, …), the glob will break and the frameworks won’t embed.

A defensive pattern is:
-inputFileListPaths = (
-  "${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks-${CONFIGURATION}-input-files.xcfilelist",
-);
+inputFileListPaths = (
+  "${PODS_ROOT}/Target Support Files/Pods-Runner/Pods-Runner-frameworks-$(CONFIGURATION)-input-files.xcfilelist",
+);
so the value is substituted by Xcode rather than by the shell.

381-424: [CP] Check Pods Manifest.lock script: quote paths containing spaces

The script references
"${PODS_PODFILE_DIR_PATH}/Podfile.lock" and "${PODS_ROOT}/Manifest.lock".
If either path contains spaces (common in $HOME when a user name has a space), the un-quoted diff fallback will fail.

Tiny hardening:
- diff "${PODS_PODFILE_DIR_PATH}/Podfile.lock" "${PODS_ROOT}/Manifest.lock" > /dev/null
+ /usr/bin/env diff "${PODS_PODFILE_DIR_PATH}/Podfile.lock" "${PODS_ROOT}/Manifest.lock" > /dev/null
(or wrap the whole command in set -euo pipefail).
.cursor/rules/vibe-tools.mdc (4)

6-8: Refine introduction for clarity and conciseness.
The first two sentences are repetitive (“vibe-tools is…”), consider combining them to flow smoothly and remove redundancy.

11-38: Use fenced code blocks for command examples.
Inline backticks within prose make long commands hard to read. For each command section (e.g., “Direct Model Queries,” “Ask Command Options,” etc.), wrap examples in triple-backtick blocks to preserve formatting.

92-101: Consider adding a table of contents at the top.
Given the length and number of command categories, a TOC would improve navigability.

108-121: Consolidate overlapping option descriptions.
The “General Command Options” (108–113) and “Repository Command Options” (114–121) share several flags (--provider, --model, --max-tokens). Consider inheriting from the general section or linking back, rather than duplicating descriptions.

lib/ui/contact_list/chat_list_screen.dart (1)

8-9: Remove or utilize unused imports
The go_router and Routes imports are added but not referenced in this file. Either remove these imports to clean up the code or implement the intended navigation logic (e.g., tapping a chat tile).

lib/ui/auth_flow/welcome_screen.dart (1)

102-102: Navigation updated to use go_router.

The direct GoRouter.go call is used appropriately here. For consistency with line 76, consider using a Routes helper method here as well (e.g., Routes.goToLogin(context)).
lib/config/providers/auth_provider.dart (1)
4-22: Consider adding persistence for authentication state

Currently, the authentication state is reset to false when the app restarts. For a production app, consider implementing persistence using shared preferences or another storage mechanism.
class AuthState extends ChangeNotifier {
-  bool _isAuthenticated = false;
+  bool _isAuthenticated = false;
+  
+  // Initialize from storage in constructor
+  AuthState() {
+    _loadAuthState();
+  }
+  
+  Future<void> _loadAuthState() async {
+    // Load from SharedPreferences or similar
+    // final prefs = await SharedPreferences.getInstance();
+    // _isAuthenticated = prefs.getBool('isAuthenticated') ?? false;
+    // notifyListeners();
+  }
+  
+  Future<void> _saveAuthState() async {
+    // Save to SharedPreferences or similar
+    // final prefs = await SharedPreferences.getInstance();
+    // await prefs.setBool('isAuthenticated', _isAuthenticated);
+  }

  bool get isAuthenticated => _isAuthenticated;

  void login() {
    _isAuthenticated = true;
    notifyListeners();
+   _saveAuthState();
  }

  void logout() {
    _isAuthenticated = false;
    notifyListeners();
+   _saveAuthState();
  }
}
lib/ui/chat/widgets/chat_input.dart (1)
187-191: Function name should follow Dart naming conventions.

The method deletePickedFiles should be renamed to follow Dart's camelCase naming convention.
-deletePickedFiles() {
+void deletePickedFiles() {
lib/ui/core/themes/colors.dart (1)
8-91: Consider documenting color usage patterns.

While the implementation is solid, it would be helpful to provide documentation on how different glitch colors should be used for different UI elements. This would help maintain consistency as the app grows.

Consider adding comments that describe the general usage pattern for these colors, such as:
// Color Usage Guidelines:
// - glitch50-100: Background colors for light surfaces
// - glitch200-300: Border and divider colors
// - glitch400-600: Secondary text and icon colors
// - glitch700-800: Primary text for dark mode
// - glitch900-950: Primary text for light mode and backgrounds for dark mode
.repomix-plan-filtered.txt (1)

1-1444: The .repomix-plan-filtered.txt file is a generated snapshot intended for AI analysis and should not be committed to the main codebase. It’s read-only and not part of the application logic. Please remove this file from the PR.

local-research/go_router_implementation_plan.md (3)

1-11: Remove local research document from production PR
This planning document is meant for internal research and not for production or user-facing documentation. Consider moving it to a separate docs directory or excluding it from this PR to keep the repository clean.

🧰 Tools

🪛 LanguageTool

[uncategorized] ~7-~7: Possible missing comma found.
Context: ...to get file listing... Found 210 files, approx 133628 tokens. Asking openrouter to ide...

(AI_HYDRA_LEO_MISSING_COMMA)

311-311: Remove trailing colons in Markdown headings
Multiple headings end with a colon, which violates MD026 (no trailing punctuation). Please delete the trailing : in these headings for consistency:

### Example for WelcomeScreen:

### Example for LoginScreen:

### For ChatScreen:

### For Android (add to AndroidManifest.xml):

### For iOS (update Info.plist):

Also applies to: 343-343, 384-384, 452-452, 469-469

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

311-311: Trailing punctuation in heading
Punctuation: ':'

(MD026, no-trailing-punctuation)

531-531: Add language identifier to fenced code block
The file-structure example uses a plain ``````` block; please specify a language (e.g., text or bash) to enable proper syntax highlighting and satisfy MD040.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

531-531: Fenced code blocks should have a language specified
null

(MD040, fenced-code-language)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 5e64c20 and 1889c03.

⛔ Files ignored due to path filters (2)

ios/Podfile.lock is excluded by !**/*.lock
macos/Podfile.lock is excluded by !**/*.lock

📒 Files selected for processing (40)

.context/01_rust_api.md (2 hunks)
.cursor/rules/vibe-tools.mdc (1 hunks)
.repomix-plan-filtered.txt (1 hunks)
lib/config/providers/auth_provider.dart (1 hunks)
lib/main.dart (3 hunks)
lib/routing/router.dart (0 hunks)
lib/routing/router_provider.dart (1 hunks)
lib/routing/routes.dart (2 hunks)
lib/shared/custom_button.dart (1 hunks)
lib/shared/custom_textfield.dart (1 hunks)
lib/ui/auth_flow/create_profile_screen.dart (4 hunks)
lib/ui/auth_flow/info_screen.dart (3 hunks)
lib/ui/auth_flow/key_created_screen.dart (4 hunks)
lib/ui/auth_flow/logged_screen.dart (3 hunks)
lib/ui/auth_flow/login_screen.dart (4 hunks)
lib/ui/auth_flow/welcome_screen.dart (3 hunks)
lib/ui/chat/chat_screen.dart (10 hunks)
lib/ui/chat/groupchat_screen.dart (9 hunks)
lib/ui/chat/widgets/chat_audio_item.dart (1 hunks)
lib/ui/chat/widgets/chat_input.dart (17 hunks)
lib/ui/chat/widgets/chat_reply_item.dart (2 hunks)
lib/ui/chat/widgets/contact_info.dart (1 hunks)
lib/ui/chat/widgets/message_widget.dart (3 hunks)
lib/ui/chat/widgets/reaction/reactions_dialog_widget.dart (6 hunks)
lib/ui/chat/widgets/reaction/stacked_reactions.dart (3 hunks)
lib/ui/chat/widgets/status_message_item_widget.dart (1 hunks)
lib/ui/contact_list/chat_invitation_sheet.dart (3 hunks)
lib/ui/contact_list/chat_list_screen.dart (1 hunks)
lib/ui/contact_list/group_chat_details_sheet.dart (7 hunks)
lib/ui/contact_list/new_chat_bottom_sheet.dart (1 hunks)
lib/ui/contact_list/start_chat_bottom_sheet.dart (1 hunks)
lib/ui/contact_list/widgets/chat_list_appbar.dart (1 hunks)
lib/ui/contact_list/widgets/chat_list_tile.dart (4 hunks)
lib/ui/contact_list/widgets/contact_list_tile.dart (3 hunks)
lib/ui/contact_list/widgets/empty_chat_widget.dart (1 hunks)
lib/ui/core/themes/colors.dart (1 hunks)
lib/ui/core/ui/custom_textfield.dart (1 hunks)
local-research/go_router_implementation_plan.md (1 hunks)
macos/Runner.xcodeproj/project.pbxproj (12 hunks)
macos/Runner.xcworkspace/contents.xcworkspacedata (1 hunks)

💤 Files with no reviewable changes (1)

lib/routing/router.dart

🧰 Additional context used

🪛 LanguageTool

local-research/go_router_implementation_plan.md

[uncategorized] ~7-~7: Possible missing comma found.
Context: ...to get file listing... Found 210 files, approx 133628 tokens. Asking openrouter to ide...

(AI_HYDRA_LEO_MISSING_COMMA)

[uncategorized] ~561-~561: The grammatical number of this noun doesn’t look right. Consider replacing it.
Context: ...IDs (e.g., /chats/:id) - Use extra parameter for complex objects (state.extra) - ...

(AI_EN_LECTOR_REPLACEMENT_NOUN_NUMBER)

🪛 markdownlint-cli2 (0.17.2)

local-research/go_router_implementation_plan.md

311-311: Trailing punctuation in heading
Punctuation: ':'