No accounts in switcher bug 🐞 is back

[josefinalliende]

Context

Issue #608 was about a bug in general settings screen that involved two situations with no "accounts", both in active account tile and in the account switcher. The active account case is working fine ✅ but the switcher is broken again 🐞

Some context of the changes related to this problem:

• Fix account loading on general settings page #614 fixed No Accounts Found #608 but introduced a bug in logout case Logged out account still shown in account switcher #623
• fix/account-switch-in-logout #618 fixed Logged out account still shown in account switcher #623 but switch accounts button was taking time in opening the switcher and if you clicked twice then 2 swtichers where opened.
• Perf fixes #633 fixed the issue of switcher taking time to open and the double case, but re introduced the no accounts bug in switcher

Solution

I'm not sure what would be the ideal UX, so I leave this open with some alternatives...

If accounts are not yet loaded in settings screen...

• 🅰️ Switch accounts button should be disabled until the accounts are loaded?
• 🅱️ Switch accounts sheet should open but in a loading state?

[josefinalliende]

@vladimir-krstic which alternative do you prefer? Or do you have a third one that would be better UX?

[vladimir-krstic]

Definitely add loading state. Without it, it would not be clear to a user should something happen, is he in the right place, can he switch the account.

[josefinalliende]

Ok so 🅱️ then!