This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add try-versions of prefix iterators
#14392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark0f
force-pushed
the
al-try-translate-substrate
branch
from
e029038
to
4fd841f
Compare
kianenigma
reviewed
Jun 16, 2023
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
KiChjang
reviewed
Jun 19, 2023
| /// If any decoding fails it skips it and continues to the next key. | ||
| /// | ||
| /// If draining, then the hook `OnRemoval::on_removal` is called after each removal. | ||
| pub struct PrefixIterator<T, OnRemoval = ()> { |
There was a problem hiding this comment.
Why is this wrapper type necessary when you can simply type alias this to TryPrefixIterator?
There was a problem hiding this comment.
Their iterator implementations have different items
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be very useful in migrations to avoid mistakes