Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate_values and friends just log in case of error #2695

Open
ark0f opened this issue May 30, 2023 · 1 comment
Open

translate_values and friends just log in case of error #2695

ark0f opened this issue May 30, 2023 · 1 comment
Labels
C0-bug Something isn't working D2-node Gear Node D4-test Autotests, and examples

Comments

@ark0f
Copy link
Member

ark0f commented May 30, 2023

Problem

translate_values and friends just log in case of error:

May 18 13:57:50.615 ERROR frame_support::storage: key failed to decode at [...]: Error { cause: Some(Error { cause: Some(Error { cause: None, desc: "Not enough data to fill buffer" }), desc: "Could not decode `MessageId.0`" }), desc: "Could not decode `WaitlistKey.0`" }    

It means we can somehow miss that errors (especially for our migrations)

Steps

Use incorrect old type in translate_values and you will see just logs

Possible Solution

No response

Notes

No response

Relevant Log Output

No response

@ark0f ark0f added C0-bug Something isn't working D2-node Gear Node D4-test Autotests, and examples labels May 30, 2023
@ark0f
Copy link
Member Author

ark0f commented Jul 1, 2023

Awaiting for paritytech/substrate#14392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C0-bug Something isn't working D2-node Gear Node D4-test Autotests, and examples
Projects
None yet
Development

No branches or pull requests

1 participant