Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

WIP: CI: add spellcheck #3421

Merged
merged 44 commits into from
Jul 14, 2021
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
ae00c7a
CI: add spellcheck
TriplEight Jul 5, 2021
3c63314
revert me
TriplEight Jul 5, 2021
6d3b024
CI: explicit command for spellchecker
TriplEight Jul 5, 2021
6028581
CI: explicit command for spellchecker
TriplEight Jul 5, 2021
9620a7e
CI: explicit command for spellchecker
TriplEight Jul 5, 2021
1da2bfb
CI: explicit command for spellchecker
TriplEight Jul 5, 2021
0e191ba
spellcheck: edit misspells
TriplEight Jul 8, 2021
dea9319
CI: run spellcheck on diff
TriplEight Jul 8, 2021
e760181
Merge branch 'master' into 3x8_add_spellcheck
TriplEight Jul 9, 2021
88b206d
spellcheck: edits
TriplEight Jul 9, 2021
e7d715b
spellcheck: edit misspells
TriplEight Jul 12, 2021
07b561b
spellcheck: add rules
TriplEight Jul 12, 2021
42d6df2
spellcheck: mv configs
TriplEight Jul 12, 2021
f7b0695
spellcheck: more edits
TriplEight Jul 12, 2021
0e509a8
spellcheck: chore
TriplEight Jul 12, 2021
883ae37
spellcheck: one more thing
TriplEight Jul 12, 2021
b2ead22
spellcheck: and another one
TriplEight Jul 12, 2021
6033f1d
spellcheck: seems like it doesn't get to an end
TriplEight Jul 12, 2021
af03dc1
Merge branch 'master' into 3x8_add_spellcheck
TriplEight Jul 12, 2021
6a84d4a
spellcheck: new words after rebase
TriplEight Jul 12, 2021
5c923ab
spellcheck: new words appearing out of nowhere
TriplEight Jul 12, 2021
2bd1840
chore
TriplEight Jul 12, 2021
5ca700c
review edits
TriplEight Jul 13, 2021
8b7e7ed
more review edits
TriplEight Jul 13, 2021
95a31bf
more edits
TriplEight Jul 13, 2021
468dbff
wonky behavior
TriplEight Jul 13, 2021
13e33a5
wonky behavior 2
TriplEight Jul 13, 2021
3e306d9
wonky behavior 3
TriplEight Jul 13, 2021
92a8467
change git behavior
TriplEight Jul 13, 2021
40e8343
spellcheck: another bunch of new edits
TriplEight Jul 13, 2021
4cc96f0
spellcheck: new words are koming out of nowhere
TriplEight Jul 13, 2021
62c74ec
CI: finding the master
TriplEight Jul 13, 2021
43c631e
CI: fetching master implicitly
TriplEight Jul 13, 2021
7792c88
CI: undebug
TriplEight Jul 13, 2021
1e10266
Merge branch 'master' into 3x8_add_spellcheck
TriplEight Jul 13, 2021
eada62f
new errors
TriplEight Jul 13, 2021
405e026
a bunch of new edits
TriplEight Jul 13, 2021
28d9c25
and some more
TriplEight Jul 13, 2021
9054c53
Update node/core/approval-voting/src/approval_db/v1/mod.rs
TriplEight Jul 13, 2021
b909637
Update xcm/xcm-executor/src/assets.rs
TriplEight Jul 13, 2021
4fd09db
Apply suggestions from code review
TriplEight Jul 13, 2021
622b7f7
Suggestions from the code review
TriplEight Jul 13, 2021
5de3863
Merge branch '3x8_add_spellcheck' of github.com:paritytech/polkadot i…
TriplEight Jul 13, 2021
eb75a8e
CI: scan only changed files
TriplEight Jul 14, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .config/lingua.dic
Original file line number Diff line number Diff line change
@@ -1,4 +1,17 @@
150
fd
PVF/S
doesn
hadn
wasn
weren
ve
bool
preverify/G
deserialize
prevalidation
OOM/S
warming/S
adversary/SM
annualised/MS
Apache-2.0/M
Expand Down
2 changes: 2 additions & 0 deletions .config/spellcheck.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
lang = "en_US"
search_dirs = ["."]
extra_dictionaries = ["lingua.dic"]
skip_os_lookups = true
use_builtin = true
TriplEight marked this conversation as resolved.
Show resolved Hide resolved

[hunspell.quirks]
# `Type`'s
Expand Down
588 changes: 299 additions & 289 deletions .gitlab-ci.yml

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion file_header.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2017-2020 Parity Technologies (UK) Ltd.
// Copyright 2017-2021 Parity Technologies (UK) Ltd.
// This file is part of Polkadot.

// Polkadot is free software: you can redistribute it and/or modify
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ pub enum InvalidCandidate {
///
/// (b) The candidate triggered a code path that has lead to the process death. For example,
/// the PVF found a way to consume unbounded amount of resources and then it either exceeded
/// an rlimit (if set) or, again, invited OOM killer. Another possibility is a bug in
/// an `rlimit` (if set) or, again, invited OOM killer. Another possibility is a bug in
/// wasmtime allowed the PVF to gain control over the execution worker.
///
/// We attribute such an event to an invalid candidate in either case.
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/execute/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ impl Response {
}
}

/// The entrypoint that the spawned execute worker should start with. The socket_path specifies
/// The entrypoint that the spawned execute worker should start with. The `socket_path` specifies
/// the path to the socket used to communicate with the host.
pub fn worker_entrypoint(socket_path: &str) {
worker_event_loop("execute", socket_path, |mut stream| async move {
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/executor_intf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const CONFIG: Config = Config {
},
};

/// Runs the prevaldation on the given code. Returns a [`RuntimeBlob`] if it succeeds.
/// Runs the prevalidation on the given code. Returns a [`RuntimeBlob`] if it succeeds.
pub fn prevalidate(code: &[u8]) -> Result<RuntimeBlob, sc_executor_common::error::WasmError> {
let blob = RuntimeBlob::new(code)?;
// It's assumed this function will take care of any prevalidation logic
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/host.rs
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ mod tests {
}
}

/// Creates a new pvf which artifact id can be uniquely identified by the given number.
/// Creates a new PVF which artifact id can be uniquely identified by the given number.
fn artifact_id(descriminator: u32) -> ArtifactId {
Pvf::from_discriminator(descriminator).as_artifact_id()
}
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/prepare/queue.rs
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ mod tests {
use std::task::Poll;
use super::*;

/// Creates a new pvf which artifact id can be uniquely identified by the given number.
/// Creates a new PVF which artifact id can be uniquely identified by the given number.
fn pvf(descriminator: u32) -> Pvf {
Pvf::from_discriminator(descriminator)
}
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/prepare/worker.rs
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ fn renice(pid: u32, niceness: i32) {
}
}

/// The entrypoint that the spawned prepare worker should start with. The socket_path specifies
/// The entrypoint that the spawned prepare worker should start with. The `socket_path` specifies
/// the path to the socket used to communicate with the host.
pub fn worker_entrypoint(socket_path: &str) {
worker_event_loop("prepare", socket_path, |mut stream| async move {
Expand Down
2 changes: 1 addition & 1 deletion node/core/pvf/src/pvf.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ impl Pvf {
Self { code, code_hash }
}

/// Creates a new pvf which artifact id can be uniquely identified by the given number.
/// Creates a new PVF which artifact id can be uniquely identified by the given number.
#[cfg(test)]
pub(crate) fn from_discriminator(num: u32) -> Self {
let descriminator_buf = num.to_le_bytes().to_vec();
Expand Down