This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
WIP: CI: add spellcheck #3421
Merged
WIP: CI: add spellcheck #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TriplEight
added
A3-in_progress
github-actions
bot
added
A0-please_review
|
It would be preferable to only check the changed files for spelling mistakes, so we are not facing a giant 10k dictionary to be fixed upfront |
drahnr
reviewed
Jul 6, 2021
drahnr
reviewed
Jul 6, 2021
drahnr
reviewed
Jul 8, 2021
TriplEight
added
the
D3-trivial 🧸
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
roadmap/implementers-guide/src/node/approval/approval-voting.md
Outdated
Show resolved
Hide resolved
ordian
reviewed
Jul 13, 2021
| @@ -193,7 +197,7 @@ Basically we need to test the correctness of data flow through state FSMs descri | |||
| - Wait until the data should have been pruned. | |||
| - The data is no longer available. | |||
|
|
|||
| - Forkfulness of the relay chain is taken into account | |||
| - Fork-awareness of the relay chain is taken into account | |||
There was a problem hiding this comment.
I don't think they mean the same, forkfulness is the correct term here
There was a problem hiding this comment.
The implementation is fork-aware, so this doesn't express the same thing indeed, forkfulness is still a mouthful and not very clear.
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
ordian
reviewed
Jul 13, 2021
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| // You should have received a copy of the GNU General Public License | |||
| // along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | |||
| //! Autogenerated weights for frame_system | |||
| //! Autogenerated weights for `frame_system` | |||
There was a problem hiding this comment.
these files are autogenerated, this should be fixed in substrate cc @shawntabrizi
https://github.com/paritytech/substrate/blob/master/utils/frame/benchmarking-cli/src/template.hbs
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
Co-authored-by: Andronik Ordian <write@reusable.software>
TriplEight
added
A3-in_progress
drahnr
reviewed
Jul 14, 2021
| - git fetch origin +${CI_DEFAULT_BRANCH}:${CI_DEFAULT_BRANCH} | ||
| - time cargo spellcheck check -vvv --cfg=scripts/gitlab/spellcheck.toml --checkers hunspell --code 1 | ||
| -r $(git diff --name-only ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH}) | ||
| -r $(git diff --name-only ${CI_COMMIT_SHA} $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH})) |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: revert the debug commit and
allow_failure: truebefore merging!This suggests that the test first should be fixed/dictionary filled.
Reference:
Hunspell manual: http://manpages.ubuntu.com/manpages/bionic/man5/hunspell.5.html
Built-in hunspell affix file into
cargo-spellcheck: https://github.com/drahnr/cargo-spellcheck/blob/master/hunspell-data/en_US.aff