This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add XCM Decode Limit #3273
Merged
Add XCM Decode Limit #3273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
|
Where did 256 come from? For now I would keep it as small as possible while ensure known needed functionality is covered. I'd suggest 8. |
|
I chose 256 from the extrinsics depth limit, but conservative is good with me 👍 |
shawntabrizi
commented
Jun 17, 2021
stze
added
D1-audited 👍
gavofyork
approved these changes
Jun 17, 2021
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Jun 17, 2021
* master: Companion #9019 (max rpc payload override) (#3276) Implementers' Guide: Chain Selection (#3262) CLI: Add missing feature checking and check if someone passes a file (#3283) Export 'TakeRevenue' trait. (#3278) Add XCM Decode Limit (#3273) Allow Council to Use Scheduler (#3237) fix xcm pallet origin (#3272) extract determine_new_blocks into a separate utility (#3261) Approval checking unit tests (#3252) bridges: update finality-grandpa to 0.14.1 (#3266) malus - mockable overseer mvp (#3224) use safe math (#3249) Companion for #8920 (Control Staking) (#3260) Companion for #8949 (#3216)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a maximum XCM decode depth of 8. This prevents deeply nested XCMs which can be complex to decode.
https://github.com/paritytech/srlabs_findings/issues/94