Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

malus - mockable overseer mvp #3224

Merged
merged 39 commits into from
Jun 16, 2021
Merged

malus - mockable overseer mvp #3224

merged 39 commits into from
Jun 16, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Jun 12, 2021 •
edited
Loading

As described in #3205 implements the MVP variant w/o going all the way into proc macro land just yet (see #2949 for that).

  • add simple interception infra and a demo malicious subsystem dropping every second message
  • create [[bin]] targets for malicious nodes

Obsoletes #2696

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Jun 12, 2021
@drahnr drahnr changed the title overseer gen mvp mockable overseer mvp Jun 12, 2021
@drahnr drahnr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jun 12, 2021
@drahnr drahnr force-pushed the bernhard-overseer-gen-mvp branch from 2cac987 to dff75e1 Compare June 13, 2021 12:27
@drahnr drahnr force-pushed the bernhard-overseer-gen-mvp branch from 45c88c8 to 36be224 Compare June 13, 2021 23:04
@drahnr drahnr force-pushed the bernhard-overseer-gen-mvp branch from f4cffcf to d7960c3 Compare June 14, 2021 14:55
@drahnr drahnr changed the title mockable overseer mvp malus - mockable overseer mvp Jun 14, 2021
ordian
ordian approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks cool, just some formatting nits.

cli/src/command.rs Outdated Show resolved Hide resolved
node/service/src/overseer.rs Outdated Show resolved Hide resolved
node/service/src/overseer.rs Outdated Show resolved Hide resolved
node/service/src/overseer.rs Outdated Show resolved Hide resolved
drahnr and others added 4 commits June 15, 2021 14:27
@drahnr @ordian
Update cli/src/command.rs
a6d1213 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr @ordian
Update node/service/src/overseer.rs
f3f3711 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr
import statements and spaces
099024c
@drahnr
move them up
60fe0f4
rphmeier
rphmeier approved these changes Jun 15, 2021
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very welcome refactoring

@drahnr
Copy link
Contributor Author

drahnr commented Jun 16, 2021

Current master (40d1612b83) : 5min 47s
PR: 5min 50s

so my initial feeling of things being extra slow was wrong, just limitations of the laptop

@drahnr
Copy link
Contributor Author

drahnr commented Jun 16, 2021

bot merge

@ghost
Copy link

ghost commented Jun 16, 2021

Waiting for commit status.

@drahnr
Copy link
Contributor Author

drahnr commented Jun 16, 2021

bot merge cancel

@ghost
Copy link

ghost commented Jun 16, 2021

Merge cancelled.

@drahnr drahnr merged commit 395324a into master Jun 16, 2021
@drahnr drahnr deleted the bernhard-overseer-gen-mvp branch June 16, 2021 10:45
ordian added a commit that referenced this pull request Jun 17, 2021
@ordian
Merge branch 'master' into ao-improved-gossip-topology
e59d267 
* master:
  Companion #9019 (max rpc payload override) (#3276)
  Implementers' Guide: Chain Selection (#3262)
  CLI: Add missing feature checking and check if someone passes a file (#3283)
  Export 'TakeRevenue' trait. (#3278)
  Add XCM Decode Limit (#3273)
  Allow Council to Use Scheduler (#3237)
  fix xcm pallet origin (#3272)
  extract determine_new_blocks into a separate utility (#3261)
  Approval checking unit tests (#3252)
  bridges: update finality-grandpa to 0.14.1 (#3266)
  malus - mockable overseer mvp (#3224)
  use safe math (#3249)
  Companion for #8920 (Control Staking) (#3260)
  Companion for #8949 (#3216)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@rphmeier rphmeier rphmeier approved these changes

@eskimor eskimor Awaiting requested review from eskimor

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahnr @ordian @rphmeier