Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FRAME] Cleanup storage generator traits #5408

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

[FRAME] Cleanup storage generator traits #5408

wants to merge 20 commits into from

Conversation

Doordashcon
Copy link
Contributor

@Doordashcon Doordashcon commented Aug 19, 2024 •
edited
Loading

resolves #142

Related files in no particular order

  • value
  • map
  • nmap
  • double_map

This approach involves porting all methods defined in the respective generator traits into their respective types in storage::types and implementing storage::{StorageValue, StorageMap, StorageNMap, StorageDoubleMap}.

@Doordashcon Doordashcon requested a review from a team as a code owner August 19, 2024 12:58
@paritytech-review-bot paritytech-review-bot bot requested a review from a team August 19, 2024 12:59
@Doordashcon Doordashcon mentioned this pull request Aug 19, 2024
Closed
4 tasks
@Doordashcon
Copy link
Contributor Author

@gui1117 please review

gui1117
gui1117 reviewed Aug 23, 2024
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed carefully.
Code is correctly moved.
Tests are also correctly moved.

Some minor comments below but then I will approve it.

substrate/frame/support/src/storage/types/counted_map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/map.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/nmap.rs Outdated Show resolved Hide resolved
substrate/frame/support/src/storage/types/value.rs Outdated Show resolved Hide resolved
Doordashcon and others added 7 commits August 23, 2024 15:00
@Doordashcon
Merge branch 'master' into ddc-storage2
d9e6f19
@Doordashcon
nit core & alloc
acbea99
@Doordashcon @gui1117
remove mutate_extant func
26504bd 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@Doordashcon @gui1117
remove decode_len func
0e99bfd 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@Doordashcon @gui1117
remove StorageHasher import
5dbb4b8 
Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
@Doordashcon
nit
d9196e9
@Doordashcon
prdoc
f2e5b07
gui1117
gui1117 reviewed Aug 24, 2024
View reviewed changes
prdoc/pr_5408.prdoc Outdated Show resolved Hide resolved
@Doordashcon Doordashcon changed the title [FRAME] Cleanup storage generator types [FRAME] Cleanup storage generator traits Aug 24, 2024
gui1117
gui1117 reviewed Aug 25, 2024
View reviewed changes
prdoc/pr_5408.prdoc Outdated Show resolved Hide resolved
@gui1117
Copy link
Contributor

gui1117 commented Aug 27, 2024

CI is complaining about format you can run:

cargo +nightly-2024-04-14 fmt

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7203958

@gui1117 gui1117 added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FRAME] Cleanup storage 'generator' types
3 participants
@Doordashcon @gui1117 @paritytech-cicd-pr