Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FRAME] Cleanup storage 'generator' types #142

Open
ggwpez opened this issue Aug 4, 2023 · 8 comments · May be fixed by #5408
Open

[FRAME] Cleanup storage 'generator' types #142

ggwpez opened this issue Aug 4, 2023 · 8 comments · May be fixed by #5408
Assignees
Labels
D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@ggwpez
Copy link
Member

ggwpez commented Aug 4, 2023

Since the V1 pallet syntax is removed, it should be possible to refactor and delete folder frame/support/src/storage/generator.

(cc @thiolliere just in case you have objections)

@Doordashcon
Copy link
Contributor

Hello @ggwpez, currently looking into this 👉 👈

@ggwpez
Copy link
Member Author

ggwpez commented Aug 14, 2023

We are going to do the monorepo migration from 25. to 28. August - just FYI. All MRs not merged by then need to be migrated manually over to the new repo structure.
I think for this issue its not a big problem. It is a rather difficult one though 😅

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework. D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. and removed I7-refactor labels Aug 25, 2023
@ggwpez
Copy link
Member Author

ggwpez commented Oct 16, 2023

@0xmovses dont know what kind of issue you are looking for, maybe this one?
It is more involved, but would allow us to toss out a lot of trash. All the generator types are not needed anymore, and the implementation can happen in the actual storage types ie. here.

@0xmovses
Copy link
Contributor

Thanks @ggwpez, this is a good suggestion as I'm currently working on this semi-related issue. I'll pick this up after 👍

@0xmovses 0xmovses assigned 0xmovses and unassigned 0xmovses Oct 16, 2023
@Doordashcon
Copy link
Contributor

Hello guys, took some time off 🫶
Should send a PR for this by friday.

Happy to collaborate on this @0xmovses

@0xmovses
Copy link
Contributor

Hey @Doordashcon, let me know when you have something pushed up, I can use your refactor as an example and continue the work (if there is some still left to do).

@Doordashcon
Copy link
Contributor

HI @ggwpez, could you kindly highlight some consideration I should take note off when making these changes 🙏

@ggwpez
Copy link
Member Author

ggwpez commented Oct 23, 2023

HI @ggwpez, could you kindly highlight some consideration I should take note off when making these changes 🙏

There is no manual for this issue. It needs some experimentation and trying out to see what can be done (it is not a mentor issue).
My feeling (and that of thio as well) is that we can remove the generator types and move the remaining logic into the actual storage types.
The goal is to remove the generator folder and have less code.

@Doordashcon Doordashcon linked a pull request Aug 19, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D1-medium Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase. I4-refactor Code needs refactoring. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Status: Backlog
4 participants