-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old UI test #1289
Remove old UI test #1289
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,9 @@ fn ui() { | |
// As trybuild is using `cargo check`, we don't need the real WASM binaries. | ||
std::env::set_var("SKIP_WASM_BUILD", "1"); | ||
|
||
// Deny all warnings since we emit warnings as part of a Runtime's UI. | ||
std::env::set_var("RUSTFLAGS", "--deny warnings"); | ||
|
||
Comment on lines
+30
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We already do this in the CI job? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes but then the result is different from running it locally. |
||
let t = trybuild::TestCases::new(); | ||
t.compile_fail("tests/construct_runtime_ui/*.rs"); | ||
} |
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently it was running this test:
polkadot-sdk/substrate/test-utils/tests/basic.rs
Line 41 in 22393d5
Either way, it does not belong into a FRAME CI job.
I wonder if we still need thissubstrate_test_utils::test
macro or can usetokio::test
instead.