Remove old UI test #1289
Merged
Remove old UI test #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Aug 29, 2023
| @@ -312,9 +312,8 @@ test-frame-support: | |||
| # Ensure we run the UI tests. | |||
| RUN_UI_TESTS: 1 | |||
| script: | |||
| - time cargo test --locked -p frame-support-test --features=frame-feature-testing,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml | |||
| - time cargo test --locked -p frame-support-test --features=frame-feature-testing,frame-feature-testing-2,no-metadata-docs,try-runtime,experimental --manifest-path ./substrate/frame/support/test/Cargo.toml | |||
| - SUBSTRATE_TEST_TIMEOUT=1 time cargo test -p substrate-test-utils --release --locked -- --ignored timeout | |||
There was a problem hiding this comment.
Apparently it was running this test:
Either way, it does not belong into a FRAME CI job.
I wonder if we still need this substrate_test_utils::test macro or can use tokio::test instead.
ggwpez
added
A1-insubstantial
liamaharon
approved these changes
Aug 30, 2023
KiChjang
approved these changes
Aug 30, 2023
alvicsam
approved these changes
Aug 30, 2023
juangirini
approved these changes
Aug 30, 2023
sergejparity
approved these changes
Aug 30, 2023
bkchr
approved these changes
Aug 30, 2023
Comment on lines
+30
to
+32
| // Deny all warnings since we emit warnings as part of a Runtime's UI. | ||
| std::env::set_var("RUSTFLAGS", "--deny warnings"); | ||
|
|
There was a problem hiding this comment.
We already do this in the CI job?
There was a problem hiding this comment.
Yes but then the result is different from running it locally.
mateo-moon
approved these changes
Aug 30, 2023
bkchr
pushed a commit
that referenced
this pull request
Aug 30, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…ery/confirmation transactions (paritytech#1289)
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…ery/confirmation transactions (paritytech#1289)
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
…ery/confirmation transactions (#1289)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default bound for the Genesis builder got removed here #1221, therefore deleting the UI test.
Also cleaning up the UI CI job. Seems to have some legacy dust - i could not determine why this
substrate-test-utilswas in there 🤔