Use proper memory queries to rocksdb #308
Merged
+21
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
force-pushed
the
nv-proper-queries
branch
from
e77bfdf to
648f4e6
Compare
ordian
reviewed
Jan 5, 2020
NikVolf
force-pushed
the
nv-proper-queries
branch
from
256d8dd to
3539d1f
Compare
ordian
approved these changes
Jan 6, 2020
dvdplm
reviewed
Jan 6, 2020
There was a problem hiding this comment.
I wonder if we should try to do this the "RocksDB way" and use GetAggregatedIntProperty(). Also of interest is the rocksdb memory utility (https://github.com/facebook/rocksdb/blob/master/utilities/memory/memory_util.cc).
Sometimes the C API lacks some features. If that is the case here, let's try to get upstream to expose it. In previous cases they've been pretty quick to get things in.
|
@dvdplm I will look into it Approach in this pr offers rather consistent memory report from my observation, so it worth having it meanwhile |
Definitely agree we can do this incrementally, but let's make sure we open issues here or in upstream as needed so we don't lose track of what we'd rather do. Thanks! |
dvdplm
approved these changes
Jan 6, 2020
dvdplm
added a commit
that referenced
this pull request
Jan 14, 2020
* master: (27 commits) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) extract common kvdb tests into a crate (#301) Expose to_hex and from_hex from impl-serde (#302) Add a top level function to parity-util-mem (#298) I/O statistic for key-value databases (#294) use for_tuples (#300) Add memory extensions for LRUCache, hashbrown (#293) Add memory stats for kvdb-s (#292) Provide #[derive(MallocSizeOf)] that is actually working (#291) Move and extend impls for locking primitives (#290) Update uint README (#288) Update README.md (#287) [ci]: remove feature flags in virtual workspace (#289) Prepare releases (#286) ...
ordian
pushed a commit
that referenced
this pull request
Feb 6, 2020
* master: (56 commits) Remove libc completely (#333) update changelogs (#329) bump parity-util-mem to 0.4.2 (#328) remove libc feature from fixed-hash (#317) kvdb-rocksdb: release 0.4.2 (#327) kvdb-rocksdb: fix iter_from_prefix being slow (#326) MallocSizeOf for BTreeSet (#325) split off primitives (#323) travis: disable kvdb-web tests for chrome (#324) Expand const fn coverage (#319) uint: make zero const fn (#318) README: fix appveyor badge (#316) keccak-hash: switch benches to criterion (#315) update parity-util-mem (#309) Update features and feature dependencies (#307) Use proper memory queries to rocksdb (#308) Draft version updates and changelog (#299) Use custom error type for `from_hex` (#305) Fix typo. (#303) kvdb: remove KeyValueDBHandler (#304) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Profiling what RocksDB returns in production revealed some data:
rocksdb.estimate-table-readers-memandrocksdb.cur-size-all-mem-tablesare per-column.rocksdb.block-cache-usageis per database, even so it must be queried viadb.property_int_value_cfpassing any column (equal and shared for all columns) 🤷♀️