Skip to content

Conversation

@NikVolf
Copy link
Contributor

@NikVolf NikVolf commented Jan 1, 2020

No description provided.

@ordian ordian requested a review from dvdplm January 2, 2020 15:43
@NikVolf NikVolf force-pushed the change-log branch 2 times, most recently from 51bacca to 9a362d2 Compare January 2, 2020 18:25
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Maybe dumb question but are you sure we need breaking releases for all the crates? Aren't most changes added features (as opposed to changed behaviour)?

@NikVolf
Copy link
Contributor Author

NikVolf commented Jan 2, 2020

Nice.

Maybe dumb question but are you sure we need breaking releases for all the crates? Aren't most changes added features (as opposed to changed behaviour)?

  1. kvdb-rocksdb depends on parity-utils-mem, the latter has to be updated with major bump, so the former as well.
  2. kvdb::KeyValueDB now should implement MallocSizeOf, which is breaking change, it also propagates to other crates.
  3. Some implementation details might produce performance degradation and so we might want an option to downgrade without pain.

@NikVolf
Copy link
Contributor Author

NikVolf commented Jan 2, 2020

Would be good also to include #302

@NikVolf NikVolf force-pushed the change-log branch 2 times, most recently from b364ddc to 840b831 Compare January 3, 2020 08:28
Co-Authored-By: David <dvdplm@gmail.com>
NikVolf and others added 2 commits January 3, 2020 17:45
Co-Authored-By: Andronik Ordian <write@reusable.software>
Co-Authored-By: Andronik Ordian <write@reusable.software>
@ordian ordian merged commit 80370e7 into master Jan 3, 2020
@ordian ordian deleted the change-log branch January 3, 2020 16:25
dvdplm added a commit that referenced this pull request Jan 14, 2020
* master: (27 commits)
  update parity-util-mem (#309)
  Update features and feature dependencies (#307)
  Use proper memory queries to rocksdb (#308)
  Draft version updates and changelog (#299)
  Use custom error type for `from_hex` (#305)
  Fix typo. (#303)
  kvdb: remove KeyValueDBHandler (#304)
  extract common kvdb tests into a crate (#301)
  Expose to_hex and from_hex from impl-serde (#302)
  Add a top level function to parity-util-mem (#298)
  I/O statistic for key-value databases (#294)
  use for_tuples (#300)
  Add memory extensions for LRUCache, hashbrown (#293)
  Add memory stats for kvdb-s (#292)
  Provide #[derive(MallocSizeOf)] that is actually working (#291)
  Move and extend impls for locking primitives (#290)
  Update uint README (#288)
  Update README.md (#287)
  [ci]: remove feature flags in virtual workspace (#289)
  Prepare releases (#286)
  ...
ordian pushed a commit that referenced this pull request Feb 6, 2020
* master: (56 commits)
  Remove libc completely (#333)
  update changelogs (#329)
  bump parity-util-mem to 0.4.2 (#328)
  remove libc feature from fixed-hash (#317)
  kvdb-rocksdb: release 0.4.2 (#327)
  kvdb-rocksdb: fix iter_from_prefix being slow (#326)
  MallocSizeOf for BTreeSet (#325)
  split off primitives (#323)
  travis: disable kvdb-web tests for chrome (#324)
  Expand const fn coverage (#319)
  uint: make zero const fn (#318)
  README: fix appveyor badge (#316)
  keccak-hash: switch benches to criterion (#315)
  update parity-util-mem (#309)
  Update features and feature dependencies (#307)
  Use proper memory queries to rocksdb (#308)
  Draft version updates and changelog (#299)
  Use custom error type for `from_hex` (#305)
  Fix typo. (#303)
  kvdb: remove KeyValueDBHandler (#304)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants