Send signals in parallel #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is now based against the master branch to allow CI to do it's job. I will rebase it later. |
vstakhov
force-pushed
the
vstakhov-parallel-signals
branch
from
c988ab8
to
5eb92fa
Compare
|
It seems I cannot now change the base branch for this PR :( |
Ok, Github has fixed this issue I suppose. |
drahnr
reviewed
Jul 9, 2023
drahnr
reviewed
Jul 9, 2023
drahnr
reviewed
Jul 9, 2023
drahnr
requested changes
Jul 9, 2023
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
drahnr
approved these changes
Jul 10, 2023
sandreim
approved these changes
Jul 17, 2023
vstakhov
added a commit
that referenced
this pull request
Jul 18, 2023
* Add benchmarks * Move thread-pool feature to dev dependencies * Allow to use both async-channel and futures channels via feature flags (#48) * Allow to select between channels implementations * Fix tests * Add futures-channel tests in CI * Fix check job * feat: send signals in parallel (#51) Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> --------- Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> * Fix merge issue * Another version fix --------- Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #18
Rough architecture description.
try_send_signalfor each subsystem. This is not an async function and it is blazingly fast for the vast majority of the cases. So it is a fast path.send_signalfunction.FuturesUnorderedto allow unordered polling. When some subsystem gets ready to accept a signal it immediately receives that signal.With such an approach, we do not create unnecessary futures nor vectors of futures and we just utilise the fast path via
try_sendin the majority of this function calls.