Allow to use both async-channel and futures channels via feature flags #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drahnr
approved these changes
Jun 29, 2023
Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
vstakhov
added a commit
that referenced
this pull request
Jul 18, 2023
* Add benchmarks * Move thread-pool feature to dev dependencies * Allow to use both async-channel and futures channels via feature flags (#48) * Allow to select between channels implementations * Fix tests * Add futures-channel tests in CI * Fix check job * feat: send signals in parallel (#51) Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> --------- Co-authored-by: Bernhard Schuster <bernhard@ahoi.io> * Fix merge issue * Another version fix --------- Co-authored-by: Bernhard Schuster <bernhard@ahoi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the compatibility issue: it is still impossible to use
async-channelin Polkadot for some reasons. So far, we have no full understanding why does this happen but we want to be able to sync with the recent orchestra updates. With this change, it will be possible to select the concrete implementation of the underlying channels via features. Well, cargo features has proven to be a fragile and poor choice for it but it is complie time, so it has no cost on operations.This PR is stacked with #47