add prank* and mock* cheatcodes family support #334
+2,581
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
1 task
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
smiasojed
reviewed
Oct 2, 2025
|
|
||
| fn fund_pranked_accounts(prank_enabled: bool, account: Address) { | ||
| // Fuzzed prank addresses have no balance, so they won't exist in revive, and | ||
| // calls will fail, this is not a problem when running in REVM. |
There was a problem hiding this comment.
how is it done that account without funds can be used to trigger call in REVM - how is gas charged in this case?
There was a problem hiding this comment.
Yeah, that's something I want to investigate.
There was a problem hiding this comment.
So, I did some digging, it seems to be because for revive we want to charge the storage deposit from the pranked accounts, I can probably add some hook in there:
https://github.com/paritytech/polkadot-sdk/blob/c61e227f2c59fa0ce7df5f977dad4076ff470f00/substrate/frame/revive/src/lib.rs#L1308
But, I also don't think the funding is such a bad solution.
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
|
For pranking, couldn't you use an approach like we do in Anvil? #332 Overriding the host functions that do the account recovery |
Unless, I'm misunderstanding #332, these are two different things |
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
alexggh
changed the title
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
pkhry
approved these changes
Oct 23, 2025
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Merged
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Oct 28, 2025
Needed for: paritytech/foundry-polkadot#334. In foundry-polkadot we need the ability to be able to manipulate the `msg.sender` and the `tx.origin` that a solidity contract sees cheatcode documentation, plus the ability to mock calls and functions. Currently all create/call methods use the `bare_instantiate`/`bare_call` to run things in pallet-revive, the caller then normally gets set automatically, based on what is the call stack, but for `forge test` we need to be able to manipulate, so that we can set it to custom values. Additionally, for delegate_call, bare_call is used, so there is no way to specify we are dealing with a delegate call, so the call is not working correcly. For both this paths, we need a way to inject this information into the execution environment, hence I added an optional hooks interface that we implement from foundry cheatcodes for prank and mock functionality. ## TODO - [x] Add tests to make sure the hooks functionality does not regress. --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
github-merge-queue bot
pushed a commit
to paritytech/polkadot-sdk
that referenced
this pull request
Oct 28, 2025
Needed for: paritytech/foundry-polkadot#334. In foundry-polkadot we need the ability to be able to manipulate the `msg.sender` and the `tx.origin` that a solidity contract sees cheatcode documentation, plus the ability to mock calls and functions. Currently all create/call methods use the `bare_instantiate`/`bare_call` to run things in pallet-revive, the caller then normally gets set automatically, based on what is the call stack, but for `forge test` we need to be able to manipulate, so that we can set it to custom values. Additionally, for delegate_call, bare_call is used, so there is no way to specify we are dealing with a delegate call, so the call is not working correcly. For both this paths, we need a way to inject this information into the execution environment, hence I added an optional hooks interface that we implement from foundry cheatcodes for prank and mock functionality. ## TODO - [x] Add tests to make sure the hooks functionality does not regress. --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
filip-parity
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: paritytech/polkadot-sdk#9909
Fixes: #324
Fixes: #335
There are a few problems with the way we currently do calls:
ecx.tx.caller., when calling bare_call/bare_instantiate.bare_callfor all type of calls, and that does not allow setting any delegate call info.In this pr I ended up adding a series of hooks in pallet-revive which allows to intercept and control the flow, the interface is described here https://github.com/paritytech/polkadot-sdk/pull/9909/files#diff-62436392e75447324001e88786b55d2966415fdd7e6cf6319708c8d48a980c2fR31 and implemented in this PR.