anvil-polkadot: add impersonation #332

iulianbarbu · 2025-09-30T13:49:27Z

Motivation

Closes #242 .

Solution

Copy the cheat manager from anvil under substrate_node/impersonation.rs.
Override secp256k1_ecdsa_recover versions of sp_io crypto host functions and use them for the wasm executor of the substrate runtime.
Override kecckak_256 sp_io's hashing host functions and use it for the wasm executor of the substrate runtime.
Integration tests that go through: random account impersonation, stopping account impersonation, auto account impersonation.

...account RPC Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

...account test Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

crates/anvil-polkadot/src/api_server/server.rs

crates/anvil-polkadot/src/substrate_node/service.rs

crates/anvil-polkadot/substrate-runtime/Cargo.toml

crates/anvil-polkadot/tests/it/impersonation.rs

crates/anvil-polkadot/tests/it/utils.rs

crates/cli/src/utils/cmd.rs

iulianbarbu · 2025-09-30T13:55:36Z

Cargo.toml

 redundant-lifetimes = "warn"
 rust-2018-idioms = "warn"
 unused-must-use = "warn"
+unexpected_cfgs = { level = "warn", check-cfg = ['cfg(substrate_runtime)'] }


needed to supress some warnings after overriding the host functions

crates/anvil-polkadot/tests/it/impersonation.rs

iulianbarbu · 2025-09-30T14:46:31Z

From @alindima offline:

try to reduce Cargo.lock size if possible
remove lock from cheats manager (it is accessed in RPC calls which are serialized)
rename cheats logic specifically to impersonation (we don't cheat other than impersonation)

crates/anvil-polkadot/src/substrate_node/host.rs

alindima

LGTM overall

alindima · 2025-09-30T15:18:13Z

IIRC this could also be configured via CLI

iulianbarbu · 2025-09-30T15:22:02Z

IIRC this could also be configured via CLI

Good catch, the auto impersonation enabling can be done via CLI too. Will add support for this, thanks!

crates/anvil-polkadot/src/api_server/server.rs

crates/anvil-polkadot/src/substrate_node/host.rs

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

…alse Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Also created the impersonation manager accounting for the `enable_auto_impersonate` anvil config flag. Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

...touched Cargo.tomls Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

crates/anvil-polkadot/tests/it/mining.rs

crates/anvil-polkadot/tests/it/utils.rs

iulianbarbu · 2025-10-01T10:47:52Z

From @alindima offline:

* try to reduce Cargo.lock size if possible

* remove lock from cheats manager (it is accessed in RPC calls which are serialized)

* rename cheats logic specifically to impersonation (we don't cheat other than impersonation)

IIRC this could also be configured via CLI

cc @alindima

used impersonation naming instead of cheats everywhere (simplifying the manager to be dedicated to impersonation as well by removing the cheats state, which planned to be more generic and used for other cheats too), removed the inner lock and added support for auto impersonation setting via CLI: 61c25f0
reduced cargo.lock size: 31dcfd0 + 4e60394

@AlexandruCihodaru given our discussion offline about the toml formatters, I added a .taplo.toml config file, same as the one used by taplo itself. I don't think it is a bad idea doing it at this point, since editors differ in how they treat identation so using same formatting will simplify reviews. Alternatively we can reuse same config as for polkadot-sdk, but I don't think it is important. I might be able to do it in a separate PR but I think it is a bit pointless to revert the changes (they aren't that many and also they are simple to review). Either way please lmk your thoughts.

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

AlexandruCihodaru

Amazing job! ❤️

crates/anvil-polkadot/tests/it/impersonation.rs

crates/anvil-polkadot/tests/it/utils.rs

AlexandruCihodaru · 2025-10-04T12:16:14Z

crates/anvil-polkadot/tests/it/impersonation.rs

+    // Assert on balances after first transfer.
+    let alith_final_balance = node.get_balance(alith_account.address(), latest_block).await;
+    let dest_final_balance = node.get_balance(dest_h160, latest_block).await;
+    let existential_deposit = U256::from_str_radix("100000000000000000000", 10).unwrap();


nit: make this a constant in utils.rs because it could be useful in other tests

and make it use the constant in substrate_runtime::currency::DOLLARS under the hood

Created a u128 cost, and whenever needed as u256 I am converting it. Did it this way to avoid creating a static/lazylock (since a cost u256 creation requires calling non-const fn's like U256::from(..).unwrap(), which can not be done with consts): bcab3f9

crates/anvil-polkadot/tests/it/impersonation.rs

crates/anvil-polkadot/src/substrate_node/service.rs

crates/anvil-polkadot/tests/it/impersonation.rs

alindima

Good job!

crates/anvil-polkadot/src/substrate_node/host.rs

alindima · 2025-10-06T08:32:48Z

.config/.taplo.toml

+  "target",
+]
+
+[formatting]


do we have a CI step for checking this format? Because if we don't, it's not that useful. Not everyone uses a code editor that automatically uses taplo for formatting.

Also, where did we get this taplo format from? I am not a big fan of the rule which adds whitespace in order to align the = signs in dependency lists.

Overall I'm not really sure we need it at this point. Anyway, let's not bundle this in this PR, as it's unrelated and would be best to also ask the embedded EVM guys for feedback

do we have a CI step for checking this format?

We should add one. I can work on this in some other PR, once a taplo config makes its way into the repo.

Because if we don't, it's not that useful. Not everyone uses a code editor that automatically uses taplo for formatting.

It is not a matter of automatically using taplo with the code editor, but to configure it (assuming our code editors allows it). I thought that our team should have taplo configured already given we also opened in the past PRs against polkadot-sdk.

Also, where did we get this taplo format from? I am not a big fan of the rule which adds whitespace in order to align the = signs in dependency lists.

It is the taplo config used by the taplo-cli repo. Changing a rule or the entire taplo config is straight forward (with the caveat that all tomls from anvil-polkadot should be formatted afterward). I am fine with most of the rules, only to have all of us use the same ones.

Overall I'm not really sure we need it at this point. Anyway, let's not bundle this in this PR, as it's unrelated and would be best to also ask the embedded EVM guys for feedback

Sure, we can ask. By then I'll revert my toml changes. I hoped we can align quickly behind some "battle tested" formatting, whichever that is and assumed people can comply easily with taplo formatting in their editors (given our previous polkadot-sdk practice), and preferences to be factored in incrementally. Will open a new PR on this subject, maybe with the formatting rules of polkadot-sdk (since we know them already).

Revert here: 5d489e0

Removed taplo config: 6162666.

This could be useful, but we should request feedback on the other devs working on the repo (since it affects all of us) and make sure that it's enforced by CI (otherwise it's not that useful)

crates/anvil-polkadot/tests/it/impersonation.rs

alindima · 2025-10-06T08:50:28Z

crates/anvil-polkadot/tests/it/impersonation.rs

+    // Assert on balances after first transfer.
+    let alith_final_balance = node.get_balance(alith_account.address(), latest_block).await;
+    let dest_final_balance = node.get_balance(dest_h160, latest_block).await;
+    let existential_deposit = U256::from_str_radix("100000000000000000000", 10).unwrap();


and make it use the constant in substrate_runtime::currency::DOLLARS under the hood

crates/anvil-polkadot/tests/it/impersonation.rs

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

crates/anvil-polkadot/tests/it/impersonation.rs

iulianbarbu · 2025-10-07T09:49:31Z

Some unrelated tests are failing, will have to look into it too before merging.

alindima · 2025-10-07T10:14:23Z

Some unrelated tests are failing, will have to look into it too before merging.

I think this will fix them: #338. I think we can merge it since it's unrelated and the fix is in review

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu added 10 commits September 30, 2025 12:11

anvil-polkadot(impersonation): add impersonate...

ffef79c

...account RPC Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(tests): add tracing support

10a3388

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(misc): fix warnings

225672c

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: polish logging

0b86c79

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(impersonation): add impersonate...

6017530

...account test Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(impersonation): testing all impersonation RPCs

d29afb0

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(impersonation): polish test

14accf2

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: customize addr recovery in ReceiptExtractor

106567b

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: point to custom polkadot-sdk

69a8e92

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: fix impersonation test

481a292

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu self-assigned this Sep 30, 2025

iulianbarbu added the enhancement New feature or request label Sep 30, 2025

iulianbarbu commented Sep 30, 2025

View reviewed changes

crates/anvil-polkadot/tests/it/impersonation.rs Show resolved Hide resolved

alindima reviewed Sep 30, 2025

View reviewed changes

crates/anvil-polkadot/src/substrate_node/host.rs Outdated Show resolved Hide resolved

alindima reviewed Sep 30, 2025

View reviewed changes

iulianbarbu commented Sep 30, 2025

View reviewed changes

crates/anvil-polkadot/src/api_server/server.rs Outdated Show resolved Hide resolved

crates/anvil-polkadot/src/substrate_node/host.rs Outdated Show resolved Hide resolved

iulianbarbu added 2 commits September 30, 2025 15:24

Cargo.lock: update to latest custom polkadot-sdk

4fe4396

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: update ReceiptExtractor constructor usage

5a09b1a

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

AlexandruCihodaru self-requested a review September 30, 2025 16:35

iulianbarbu added 7 commits October 1, 2025 07:59

anvil-polkadot(tests): refactor send_transaction

e5ff766

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: fix comments and revert newlines

bd5dae5

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

foundry-cli: revert change

31dcfd0

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

Cargo.lock: fix unwanted crates updates

4e60394

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(tests): assert tx failure when auto impersonation is f…

affa8e5

…alse Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: rename cheats manager to impersonation

61c25f0

Also created the impersonation manager accounting for the `enable_auto_impersonate` anvil config flag. Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot: cargo fmt fix

b4d4948

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu added 2 commits October 1, 2025 10:08

anvil-polkadot: fix typo

bcc7555

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

taplo: added config and formatted...

d37ae56

...touched Cargo.tomls Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu commented Oct 1, 2025

View reviewed changes

crates/anvil-polkadot/tests/it/mining.rs Outdated Show resolved Hide resolved

crates/anvil-polkadot/tests/it/utils.rs Outdated Show resolved Hide resolved

iulianbarbu added 2 commits October 1, 2025 13:41

Update crates/anvil-polkadot/tests/it/utils.rs

53fc8d8

Update crates/anvil-polkadot/tests/it/mining.rs

dcdf5c3

iulianbarbu requested a review from re-gius October 1, 2025 10:48

iulianbarbu marked this pull request as ready for review October 1, 2025 10:48

Cargo.toml: changed back to polkadot-sdk/master

991d8c3

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu requested a review from skunert October 1, 2025 12:35

iulianbarbu mentioned this pull request Oct 2, 2025

[Anvil] Impersonation #242

Closed

AlexandruCihodaru approved these changes Oct 4, 2025

View reviewed changes

alindima mentioned this pull request Oct 6, 2025

add prank* and mock* cheatcodes family support #334

Open

alindima reviewed Oct 6, 2025

View reviewed changes

iulianbarbu added 3 commits October 6, 2025 11:26

anvil-polkadot: address feedback

bcab3f9

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

tomls: revert formatting

5d489e0

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

taplo: remove config

6162666

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

alindima approved these changes Oct 6, 2025

View reviewed changes

crates/anvil-polkadot/tests/it/impersonation.rs Outdated Show resolved Hide resolved

iulianbarbu and others added 3 commits October 7, 2025 15:14

Merge branch 'master' into ib-add-impersonation

f9d868f

anvil-polkadot(tests): parameterize auto_impersonate test with rstest

6e34608

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

anvil-polkadot(toml): fix cargo.toml formatting

cac0a84

Signed-off-by: Iulian Barbu <iulian.barbu@parity.io>

iulianbarbu enabled auto-merge (squash) October 7, 2025 13:26

iulianbarbu merged commit 26eda0d into master Oct 7, 2025
30 checks passed

iulianbarbu deleted the ib-add-impersonation branch October 7, 2025 15:07

iulianbarbu mentioned this pull request Oct 20, 2025

Allow account impersonation same as EDR paritytech/contract-issues#170

Open

anvil-polkadot: add impersonation #332

anvil-polkadot: add impersonation #332

Conversation

iulianbarbu commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iulianbarbu commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

alindima left a comment

Choose a reason for hiding this comment

Uh oh!

alindima commented Sep 30, 2025

Uh oh!

iulianbarbu commented Sep 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iulianbarbu commented Oct 1, 2025

Uh oh!

AlexandruCihodaru left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alindima left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alindima Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iulianbarbu commented Oct 7, 2025

Uh oh!

alindima commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

iulianbarbu commented Sep 30, 2025 •

edited

Loading

iulianbarbu commented Sep 30, 2025 •

edited

Loading

alindima Oct 6, 2025 •

edited

Loading

alindima commented Oct 7, 2025 •

edited

Loading