Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #2990

Merged
merged 4 commits into from
May 7, 2019
Merged

Fix CI #2990

merged 4 commits into from
May 7, 2019

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented May 7, 2019

↪️ Pull Request

Redid the test fixes based on the more complete #2842

Closes #2842

💻 Examples

🚨 Test instructions

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

* Fix error from duplicated type (T is already declared)

* Fix code format by running `yarn format`

* Fix failed test caused by Babel

More info: #2842 (comment)

* Fix failed test on fs-destructure

Not sure what's the root cause but upgrading all babel dependencies to the current latest version fix the issue.

* Try bumping elm packages version hoping this will fix failed tests

* Fix corejs warning

According to #2842 (comment)

* Upgrade @babel dependencies

* Upgrade elm dependencies
@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented May 7, 2019

For some reason Node 6 keeps failing randomly, would probably be helpfull to merge this in to master anyway as it still gives us an indication to whether a PR actually breaks anything.

@mischnic
Copy link
Member

mischnic commented May 7, 2019

Maybe reenabling the spec reporter for the integration tests gives a clue why it fails without an error:

"reporterEnabled": "mocha-junit-reporter",

@mischnic
Copy link
Member

mischnic commented May 7, 2019

@devongovett This would "update" babel to the latest version, was #2819 resolved? Will the correct core-js package be used if it's specified as a dependency by Parcel (version 2)? Or might some other hoisted version (3, might cause errors) be bundled?

Wait, some babel deps are now <7.4.0 and some others >7.4.0 which seems wrong

@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented May 7, 2019

Everything passed 🎉🎉🎉

@DeMoorJasper DeMoorJasper mentioned this pull request May 7, 2019
3 tasks
@devongovett devongovett merged commit 897cb1c into master May 7, 2019
@devongovett devongovett deleted the fix-tests-2 branch May 7, 2019 22:06
twome added a commit to twome/parcel that referenced this pull request May 12, 2019
…e/strip-type-module-attr

* 'master' of github.com:parcel-bundler/parcel:
  Update deps & gitattributes (parcel-bundler#3006)
  Fix assigning to exports from inside a function in scope hoisting (parcel-bundler#2994)
  Define __esModule interop flag when requiring ES module from CommonJS (parcel-bundler#2993)
  Replace module.require in scope hoisting (parcel-bundler#2875)
  Clear scope cache before crawling (parcel-bundler#2986)
  Fix CI (parcel-bundler#2990)
  Shake exports with pure property assignments (parcel-bundler#2979)
  Update postcss.js (parcel-bundler#2922)
  Fail immediately if yarn.lock updates are needed (parcel-bundler#2945)

# Conflicts:
#	packages/core/parcel-bundler/package.json
#	yarn.lock
twome added a commit to twome/parcel that referenced this pull request Sep 10, 2019
…e/strip-type-module-attr

* 'master' of github.com:parcel-bundler/parcel:
  fix source maps on coffeescript assets (parcel-bundler#3423)
  Fixes parcel-bundler#3133 by upgrading serialize-to-js from 1.1.1 to 3.0.0  (parcel-bundler#3451)
  Fix up misleading usage information (parcel-bundler#3158)
  bump chokidar to get a reload fix for linux (parcel-bundler#2878)
  Use uppercase for the first letter of the issue template (parcel-bundler#3192)
  Update dotenv-expand to allow overriding of falsy values (parcel-bundler#2971)
  Fixes 3076: HMR update breaks in webworker due to window (and location.reload) not existing in web worker context. (parcel-bundler#3078)
  Scope hoisting destructuring (parcel-bundler#2742)
  Create FUNDING.yml (parcel-bundler#3074)
  Added new info command  (parcel-bundler#3068)
  Fix typo (parcel-bundler#3043)
  Update deps & gitattributes (parcel-bundler#3006)
  Fix assigning to exports from inside a function in scope hoisting (parcel-bundler#2994)
  Define __esModule interop flag when requiring ES module from CommonJS (parcel-bundler#2993)
  Replace module.require in scope hoisting (parcel-bundler#2875)
  Clear scope cache before crawling (parcel-bundler#2986)
  Fix CI (parcel-bundler#2990)
  Shake exports with pure property assignments (parcel-bundler#2979)
  Update postcss.js (parcel-bundler#2922)
  Fail immediately if yarn.lock updates are needed (parcel-bundler#2945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants