Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing the tests in master #2982

Closed
wants to merge 13 commits into from
Closed

Attempt at fixing the tests in master #2982

wants to merge 13 commits into from

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented May 6, 2019

↪️ Pull Request

Closes #2842 closes #2935

🚨 Test instructions

yarn test shouldn't throw errors

@mischnic
Copy link
Member

mischnic commented May 6, 2019

Related: #2842

@@ -52,7 +52,7 @@ describe('fs', function() {
assert.equal(output, 'hello');
});

it('should inline a file with fs require destructure', async function() {
it.skip('should inline a file with fs require destructure', async function() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is related to babel issues afaik, skipped it for now as babel was locked to <7.4 due to bugs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

locked to <7.4 due to bugs.

How long will it stay it that way?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure Devon locked it, perhaps the bugs have already been fixed

cc @devongovett

Copy link
Member

@mischnic mischnic May 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue atm with the old babel: This experimental syntax requires enabling the parser plugin: 'objectRestSpread' if a package contains rest spread (which isn't even a proposal anymore)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe babel is fixed now, so we can upgrade it again.

@DeMoorJasper DeMoorJasper requested a review from mischnic May 6, 2019 17:36
@mischnic
Copy link
Member

mischnic commented May 6, 2019

The tests pass on my machine, but the output is strange:


  FSCache
    ✓ should create directory on ensureDirExists (76ms)
(node:9100) UnhandledPromiseRejectionWarning: #<Object>
(node:9100) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:9100) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:9100) UnhandledPromiseRejectionWarning: #<Object>
(node:9100) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 2)
    ✓ should cache resources (81ms)
    ✓ should return null for invalidated resources
    ✓ should remove file on delete (72ms)
    ✓ should remove from invalidated on write (63ms)

@DeMoorJasper
Copy link
Member Author

@mischnic that's very strange but probably not caused by this PR

mischnic
mischnic previously approved these changes May 6, 2019
@DeMoorJasper
Copy link
Member Author

DeMoorJasper commented May 7, 2019

Opened a new PR #2990

@DeMoorJasper DeMoorJasper deleted the fix-tests branch May 7, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants