-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt at fixing the tests in master #2982
Conversation
Related: #2842 |
@@ -52,7 +52,7 @@ describe('fs', function() { | |||
assert.equal(output, 'hello'); | |||
}); | |||
|
|||
it('should inline a file with fs require destructure', async function() { | |||
it.skip('should inline a file with fs require destructure', async function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is related to babel issues afaik, skipped it for now as babel was locked to <7.4 due to bugs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
locked to <7.4 due to bugs.
How long will it stay it that way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure Devon locked it, perhaps the bugs have already been fixed
cc @devongovett
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One issue atm with the old babel: This experimental syntax requires enabling the parser plugin: 'objectRestSpread'
if a package contains rest spread (which isn't even a proposal anymore)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe babel is fixed now, so we can upgrade it again.
The tests pass on my machine, but the output is strange:
|
@mischnic that's very strange but probably not caused by this PR |
Opened a new PR #2990 |
↪️ Pull Request
Closes #2842 closes #2935
🚨 Test instructions
yarn test
shouldn't throw errors