Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification in currency adapter #639

Merged
merged 10 commits into from
Sep 26, 2021
Merged

Modification in currency adapter #639

merged 10 commits into from
Sep 26, 2021

Conversation

ashi20192020
Copy link
Contributor

resolves #613

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #639 (cc34703) into master (f8cf806) will increase coverage by 1.38%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   51.17%   52.56%   +1.38%     
==========================================
  Files          67       67              
  Lines        4166     4056     -110     
==========================================
  Hits         2132     2132              
+ Misses       2034     1924     -110     
Impacted Files Coverage Δ
pallets/amm/src/lib.rs 0.00% <0.00%> (ø)
pallets/amm/src/mock.rs 0.00% <ø> (ø)
pallets/amm/src/pool_structs.rs 0.00% <0.00%> (ø)
pallets/currency-adapter/src/lib.rs 0.00% <0.00%> (ø)
pallets/router/src/lib.rs 0.00% <ø> (ø)
runtime/parallel/src/lib.rs 0.00% <ø> (ø)
runtime/vanilla/src/lib.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8cf806...cc34703. Read the comment docs.

@GopherJ
Copy link
Contributor

GopherJ commented Sep 25, 2021

it looks good, can you fix tests? @ayushmishra2005

@ashi20192020
Copy link
Contributor Author

it looks good, can you fix tests? @ayushmishra2005

Yes @GopherJ . Its not ready. Some main code changes are still left. I am working on it.

@ashi20192020 ashi20192020 marked this pull request as ready for review September 26, 2021 03:58
@GopherJ
Copy link
Contributor

GopherJ commented Sep 26, 2021

adapter is too general, we can maybe name it pallet-currency-adapter etc

@ashi20192020
Copy link
Contributor Author

adapter is too general, we can maybe name it pallet-currency-adapter etc

Done @GopherJ

@GopherJ GopherJ mentioned this pull request Sep 26, 2021
11 tasks
pallets/amm/src/lib.rs Outdated Show resolved Hide resolved
runtime/parallel/src/lib.rs Outdated Show resolved Hide resolved
@GopherJ GopherJ self-requested a review September 26, 2021 08:22
@GopherJ GopherJ merged commit ab9ce95 into master Sep 26, 2021
@GopherJ GopherJ deleted the currency_adapter_2 branch September 26, 2021 08:35
@GopherJ
Copy link
Contributor

GopherJ commented Sep 26, 2021

let's merge so that we can continue, @ETeissonniere dont hesitate if you got time to review

GopherJ added a commit that referenced this pull request Sep 26, 2021
* Modification in currency adapter

* Replaced CurrencyId with AssetId

* Added Adapter pallet

* Integrated Adapter in runtime and fixed test-cases

* Fixed Router test-cases

* Fixed Router benchmarking

* Rename adapter

* Removed clippy warning

* add pallet overview, rename AMMCurrency, fix constants & parallel-runtime's native currency

Co-authored-by: Ayush <>
Co-authored-by: Cheng JIANG <alex_cj96@foxmail.com>
Copy link
Contributor

@ETeissonniere ETeissonniere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract currency adapter to a common place
5 participants