-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modification in currency adapter #639
Conversation
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
+ Coverage 51.17% 52.56% +1.38%
==========================================
Files 67 67
Lines 4166 4056 -110
==========================================
Hits 2132 2132
+ Misses 2034 1924 -110
Continue to review full report at Codecov.
|
it looks good, can you fix tests? @ayushmishra2005 |
Yes @GopherJ . Its not ready. Some main code changes are still left. I am working on it. |
adapter is too general, we can maybe name it |
Done @GopherJ |
44481b4
to
8b9fbc5
Compare
…time's native currency
8b9fbc5
to
e82caf8
Compare
let's merge so that we can continue, @ETeissonniere dont hesitate if you got time to review |
* Modification in currency adapter * Replaced CurrencyId with AssetId * Added Adapter pallet * Integrated Adapter in runtime and fixed test-cases * Fixed Router test-cases * Fixed Router benchmarking * Rename adapter * Removed clippy warning * add pallet overview, rename AMMCurrency, fix constants & parallel-runtime's native currency Co-authored-by: Ayush <> Co-authored-by: Cheng JIANG <alex_cj96@foxmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge
resolves #613