Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcm v1 #637

Merged
merged 18 commits into from
Sep 29, 2021
Merged

xcm v1 #637

merged 18 commits into from
Sep 29, 2021

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Sep 24, 2021

close: #376
close: #618
close: #641

TODO before entering master:

  • build & publish parallelfinance/polkadot:v0.9.10 docker image
  • test cross chain transfer against the new docker image
  • fix loans benchmarks' logic
  • add loans benchmarks to runtimes
  • test make launch still works
  • switch to orml master when xcm v1 PR is merged
  • switch to polkadot-release-v0.9.10's final commit
  • update changelog
  • rename AssetIdentifier to CurrencyId after Modification in currency adapter #639

TODO after entering master:

  • parallel-js update, don't use AssetId, use CurrencyId instead
  • parallel-dapp should then use xcm v1 instead of xcm v0

@GopherJ GopherJ force-pushed the feat/xcm-v1 branch 4 times, most recently from 7db51ce to 137c656 Compare September 24, 2021 01:44
@GopherJ GopherJ changed the title wip: xcm v1 xcm v1 Sep 25, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2021

Codecov Report

Merging #637 (84ad4e8) into master (ab9ce95) will decrease coverage by 0.63%.
The diff coverage is 25.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
- Coverage   52.68%   52.04%   -0.64%     
==========================================
  Files          67       67              
  Lines        4047     4091      +44     
==========================================
- Hits         2132     2129       -3     
- Misses       1915     1962      +47     
Impacted Files Coverage Δ
node/parallel/src/client.rs 0.00% <ø> (ø)
pallets/amm/src/lib.rs 0.00% <0.00%> (ø)
pallets/amm/src/mock.rs 0.00% <ø> (ø)
pallets/amm/src/pool_structs.rs 0.00% <ø> (ø)
pallets/currency-adapter/src/lib.rs 0.00% <ø> (ø)
pallets/liquid-staking-v2/src/lib.rs 68.42% <ø> (ø)
pallets/liquidation/src/lib.rs 0.00% <ø> (ø)
pallets/loans/rpc/src/lib.rs 0.00% <ø> (ø)
pallets/router/src/lib.rs 0.00% <ø> (ø)
primitives/src/currency.rs 41.66% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab9ce95...84ad4e8. Read the comment docs.

@GopherJ GopherJ marked this pull request as draft September 25, 2021 05:03
@GopherJ GopherJ marked this pull request as ready for review September 25, 2021 05:48
@GopherJ GopherJ requested review from yz89 and mclyk and removed request for yz89 September 25, 2021 06:01
runtime/heiko/src/lib.rs Outdated Show resolved Hide resolved
@GopherJ GopherJ force-pushed the feat/xcm-v1 branch 2 times, most recently from 2e0b87f to 6d24a96 Compare September 25, 2021 17:27
Copy link
Contributor

@mclyk mclyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, let's see when orml merge sw/xcm-v1.

runtime/vanilla/Cargo.toml Outdated Show resolved Hide resolved
@GopherJ
Copy link
Contributor Author

GopherJ commented Sep 26, 2021

I cannot test cross chain yet, the current polkadot apps UI looks like:

image

Blocked by: polkadot-js/apps#6199

@GopherJ
Copy link
Contributor Author

GopherJ commented Sep 26, 2021

If I use MultiAsset v0 it'll work:

image

@GopherJ GopherJ force-pushed the feat/xcm-v1 branch 2 times, most recently from b977021 to fbf0178 Compare September 26, 2021 11:22
@GopherJ GopherJ merged commit 5900e4b into master Sep 29, 2021
@GopherJ GopherJ deleted the feat/xcm-v1 branch September 29, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants