General code quality improvements

parsec-openssl-provider-shared/src/lib.rs

@@ -1,5 +1,6 @@
 // Copyright 2023 Contributors to the Parsec project.
 // SPDX-License-Identifier: Apache-2.0
+#![deny(warnings)]
 
 use parsec_openssl_provider::{openssl_errors, parsec_provider_provider_init};
 

parsec-openssl-provider/src/lib.rs

@@ -1,6 +1,7 @@
 // Copyright 2023 Contributors to the Parsec project.
 // SPDX-License-Identifier: Apache-2.0
 #![allow(clippy::missing_safety_doc)]
+#![deny(warnings)]
 
 use std::sync::Arc;
 

parsec-openssl-provider/src/provider.rs

@@ -40,7 +40,7 @@ const PARSEC_PROVIDER_PARAM_TYPES: [OSSL_PARAM; 5] = [
 ];
 
 pub struct ParsecProviderContext {
-    pub client: BasicClient,
+    client: BasicClient,
 }
 
 impl ParsecProviderContext {

parsec-openssl-sys2/src/lib.rs

@@ -1,5 +1,6 @@
 // Copyright 2023 Contributors to the Parsec project.
 // SPDX-License-Identifier: Apache-2.0
+#![deny(warnings)]
 
 #[allow(non_camel_case_types)]
 #[allow(non_upper_case_globals)]

parsec-openssl2/src/lib.rs

@@ -1,6 +1,7 @@
 // Copyright 2023 Contributors to the Parsec project.
 // SPDX-License-Identifier: Apache-2.0
 #![allow(clippy::missing_safety_doc)]
+#![deny(warnings)]
 
 pub use openssl_sys::OSSL_PROVIDER;
 pub use parsec_openssl_sys2::openssl_bindings;

tests/ci.sh

@@ -41,8 +41,6 @@ if [[ ! -z ${RUST_TOOLCHAIN_VERSION:+x} ]]; then
 	rustup override set ${RUST_TOOLCHAIN_VERSION}
 fi
 
-rustup update
-
 BUILD="False"
 TEST="False"
 STATIC_CHECKS="False"
@@ -70,6 +68,8 @@ while [ "$#" -gt 0 ]; do
     shift
 done
 
+rustup update
+
 if [ "$BUILD" == "True" ]; then
     echo "OpenSSL version being used:"
     openssl version