General code quality improvements #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgonzalezorlandoarm
commented
Apr 10, 2024
tgonzalezorlandoarm
commented
- Turn compilation warnings into errors
- Validate ci.sh inputs before any logic is run
- Make only required attributes public, otherwise use the getter methods
Currently, no warnings are produced. This will guarantee a certain code quality in the project. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
The script's logic should only be run after the options and arguments provided have been validated. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Do not expose client as this is not required and use the get_client method instead. Signed-off-by: Tomás González <tomasagustin.gonzalezorlando@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.