Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move OP payload builder error to OP crate #5940

Merged
merged 1 commit into from
Jan 4, 2024
Merged

chore: move OP payload builder error to OP crate #5940

merged 1 commit into from
Jan 4, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jan 4, 2024

move error type to op crate and add PayloadBuilderError::other

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-op-reth Related to Optimism and op-reth labels Jan 4, 2024
@mattsse mattsse added this pull request to the merge queue Jan 4, 2024
Merged via the queue into main with commit e3c3ddc Jan 4, 2024
28 checks passed
@mattsse mattsse deleted the matt/move-op-payload-builder-error branch January 4, 2024 16:59
@emhane emhane mentioned this pull request May 30, 2024
Open
@emhane emhane mentioned this pull request Jun 20, 2024
Closed
@emhane emhane mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk rkrasiuk approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-op-reth Related to Optimism and op-reth C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @rkrasiuk