Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature = "optimism" from reth-optimism-payload-builder #6906

Closed
1 task done
Tracked by #7649
DaniPopes opened this issue Mar 1, 2024 · 3 comments
Closed
1 task done
Tracked by #7649

Remove feature = "optimism" from reth-optimism-payload-builder #6906

DaniPopes opened this issue Mar 1, 2024 · 3 comments
Assignees
Labels
C-debt Refactor of code section that is hard to understand or maintain

Comments

@DaniPopes
Copy link
Member

DaniPopes commented Mar 1, 2024

Describe the feature

The feature doesn't make sense as the entire crate is only imported when building op-reth.

Remove [features] optimism = [] and all cfg inside of the crate.

Additional context

No response

Tasks

  1. A-op-reth C-debt
@DaniPopes DaniPopes added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt Refactor of code section that is hard to understand or maintain labels Mar 1, 2024
@mattsse
Copy link
Collaborator

mattsse commented Mar 1, 2024

I think this should be possible now

@AbnerZheng
Copy link
Contributor

Could I give it a try?

@AbnerZheng
Copy link
Contributor

AbnerZheng commented Mar 4, 2024

I attempted to remove the features=optimism and create a PR, but it appears to be unsuccessful. In my PR, the reth-optimism-payload-builder is a workspace member and it require the activation of the optimism feature in reth-primitives. However, other crates require the optimism feature of reth-primitives to be deactivated when running make lint(no optimism enabled). This is incompatible with Cargo's feature resolution, which builds a dependency with the union of all features enabled by any package that depends on it.
https://doc.rust-lang.org/cargo/reference/features.html#feature-unification

@emhane emhane removed C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started labels Aug 22, 2024
@emhane emhane closed this as completed Aug 22, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants