Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(snapshot): debug assertion methods #4851

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix(snapshot): debug assertion methods #4851

merged 1 commit into from
Sep 29, 2023

Conversation

shekhirin
Copy link
Collaborator

@shekhirin shekhirin commented Sep 29, 2023 •
edited
Loading

Same as #4846, I accidentally merged these cfgs in #4721.

@shekhirin shekhirin added C-bug An unexpected or incorrect behavior A-static-files Related to static files labels Sep 29, 2023
mattsse
mattsse approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 29, 2023 •
edited
Loading

Codecov Report

Merging #4851 (a7a6b76) into main (6b29454) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

Files Coverage Δ
crates/snapshot/src/snapshotter.rs 94.31% <ø> (ø)

... and 10 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.54% <ø> (+<0.01%) ⬆️
unit-tests 62.76% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.02% <ø> (ø)
blockchain tree 83.76% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 73.31% <ø> (ø)
trie 94.44% <ø> (-0.04%) ⬇️
txpool 49.54% <ø> (ø)
networking 76.59% <ø> (+0.10%) ⬆️
rpc 57.78% <ø> (-0.01%) ⬇️
consensus 61.06% <ø> (ø)
revm 28.54% <ø> (ø)
payload builder 8.16% <ø> (ø)
primitives 85.29% <ø> (ø)

@shekhirin shekhirin added this pull request to the merge queue Sep 29, 2023
Merged via the queue into main with commit 53ff254 Sep 29, 2023
23 checks passed
@shekhirin shekhirin deleted the alexey/fix-snapshotter-release-build-again branch September 29, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-static-files Related to static files C-bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shekhirin @mattsse