-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(snapshot, prune): highest snapshots tracker #4721
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
2 times, most recently
from
September 21, 2023 18:46
c32a6e4
to
3e23b11
Compare
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 21, 2023 18:52
3e23b11
to
d986eb8
Compare
shekhirin
requested review from
joshieDo,
rkrasiuk,
mattsse,
Rjected,
onbjerg and
gakonst
as code owners
September 22, 2023 13:00
shekhirin
added
A-pruning
Related to pruning or full node
A-static-files
Related to static files
C-enhancement
New feature or request
labels
Sep 22, 2023
Closed
Codecov Report
... and 7 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…o alexey/pruner-highest-snapshots
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
2 times, most recently
from
September 27, 2023 16:19
bfd231b
to
6e5ff22
Compare
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 27, 2023 16:41
6e5ff22
to
aa35d53
Compare
shekhirin
changed the title
feat(snapshot, prune): respect highest snapshots in pruner
feat(snapshot, prune): highest snapshots tracker
Sep 27, 2023
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 27, 2023 17:37
7045ba8
to
db2d084
Compare
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 27, 2023 18:01
db2d084
to
17e030a
Compare
joshieDo
approved these changes
Sep 28, 2023
mattsse
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…o alexey/pruner-highest-snapshots
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 29, 2023 09:42
cfa12f6
to
10dcc1a
Compare
shekhirin
force-pushed
the
alexey/pruner-highest-snapshots
branch
from
September 29, 2023 09:42
10dcc1a
to
15f33b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-pruning
Related to pruning or full node
A-static-files
Related to static files
C-enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When highest snapshotted block numbers for transactions or headers are known, pruner should act prune this tables too.
This PR adds a tracker for highest snapshots and initiates a
Snapshotter
inside thenode/mod.rs
.