Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated log line #4719

Merged
merged 1 commit into from
Sep 21, 2023
Merged

remove deprecated log line #4719

merged 1 commit into from
Sep 21, 2023

Conversation

idatsy
Copy link
Contributor

@idatsy idatsy commented Sep 21, 2023

The --log-persistent flag is now default. Running the docker compose at etc/docker-compose.yml doesn't work. Flag needs to be removed. --log-persistent is now deafult.

When running the docker compose file (as described in the reth book) in etc/docker-compose.yml:

Usage: reth node --chain <CHAIN_OR_PATH> --metrics <SOCKET> --log.filter <FILTER>
reth-reth-1  | 
reth-reth-1  | For more information, try '--help'.
reth-reth-1  | error: unexpected argument '--log.persistent' found
reth-reth-1  | 
reth-reth-1  |   tip: a similar argument exists: '--log.filter’

@idatsy
Copy link
Contributor Author

idatsy commented Sep 21, 2023

Discussed in: 4718

@mattsse mattsse added the C-debt Refactor of code section that is hard to understand or maintain label Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #4719 (3e85857) into main (bb0da4a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

see 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.73% <ø> (-0.02%) ⬇️
unit-tests 63.31% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 32.17% <ø> (ø)
blockchain tree 83.73% <ø> (ø)
pipeline 88.53% <ø> (ø)
storage (db) 72.52% <ø> (ø)
trie 94.73% <ø> (-0.04%) ⬇️
txpool 49.82% <ø> (-0.49%) ⬇️
networking 77.11% <ø> (-0.02%) ⬇️
rpc 57.86% <ø> (ø)
consensus 63.09% <ø> (ø)
revm 28.33% <ø> (ø)
payload builder 8.35% <ø> (ø)
primitives 86.51% <ø> (-0.04%) ⬇️

@mattsse mattsse added this pull request to the merge queue Sep 21, 2023
Merged via the queue into paradigmxyz:main with commit 48231c8 Sep 21, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants