Outdated etc/docker-compose.yml

[idatsy]

Describe the bug

The --log-persistent flag is now default. Running the docker compose at etc/docker-compose.yml doesn't work. Flag needs to be removed. I'd fix it in 5 sec but don't have access :)

Steps to reproduce

./etc/generate-jwt.sh
docker compose -f etc/docker-compose.yml -f etc/lighthouse.yml up -d

Node logs

When running the docker compose file (as described in the reth book) in etc/docker-compose.yml:


Usage: reth node --chain <CHAIN_OR_PATH> --metrics <SOCKET> --log.filter <FILTER>
reth-reth-1  | 
reth-reth-1  | For more information, try '--help'.
reth-reth-1  | error: unexpected argument '--log.persistent' found
reth-reth-1  | 
reth-reth-1  |   tip: a similar argument exists: '--log.filter’

### Platform(s)

_No response_

### What version/commit are you on?

_No response_

### What database version are you on?

_No response_

### If you've built Reth from source, provide the full command you used

_No response_

### Code of Conduct

- [X] I agree to follow the Code of Conduct

[0xprames]

thats weird bc I can't repro o.o:

[+] Running 12/12
 ✔ Network reth_default               Created                                                                                                                                     0.1s
 ✔ Volume "reth_rethlogs"             Created                                                                                                                                     0.0s
 ✔ Volume "reth_grafanadata"          Created                                                                                                                                     0.0s
 ✔ Volume "reth_lighthousedata"       Created                                                                                                                                     0.0s
 ✔ Volume "reth_prometheusdata"       Created                                                                                                                                     0.0s
 ✔ Volume "reth_rethdata_mainnet"     Created                                                                                                                                     0.0s
 ✔ Volume "reth_rethdata_sepolia"     Created                                                                                                                                     0.0s
 ✔ Container reth-reth-1              Started                                                                                                                                     1.3s
 ✔ Container reth-lighthouse-1        Started                                                                                                                                     1.5s
 ✔ Container reth-prometheus-1        Started                                                                                                                                     1.5s
 ✔ Container reth-grafana-1           Started                                                                                                                                     1.9s
 ✔ Container reth-metrics-exporter-1  Started                                                                                                                                     1.8s
docker compose -f docker-compose.yml -f lighthouse.yml up -d

[+] Running 5/0
 ✔ Container reth-reth-1              Running                                                                                                                                     0.0s
 ✔ Container reth-prometheus-1        Running                                                                                                                                     0.0s
 ✔ Container reth-lighthouse-1        Running                                                                                                                                     0.0s
 ✔ Container reth-grafana-1           Running                                                                                                                                     0.0s
 ✔ Container reth-metrics-exporter-1  Running    

docker inspect:

"Cmd": [
                "node",
                "--chain",
                "mainnet",
                "--metrics",
                "0.0.0.0:9001",
                "--log.persistent",
                "--log.directory",
                "/root/rethlogs",
                "--authrpc.addr",
                "0.0.0.0",
                "--authrpc.port",
                "8551",
                "--authrpc.jwtsecret",
                "/root/jwt/jwt.hex",
                "--http",
                "--http.addr",
                "0.0.0.0",
                "--http.port",
                "8545",
                "--http.api",
                "eth,net,web3"
            ],

docker logs of reth container:

docker logs 66355354ac59
2023-09-21T16:55:49.406635Z  INFO reth::cli: reth 0.1.0-alpha.8 (0f14ec4) starting
2023-09-21T16:55:49.407430Z  INFO reth::cli: Configuration loaded path="/root/.local/share/reth/mainnet/reth.toml"
2023-09-21T16:55:49.407541Z  INFO reth::cli: Opening database path="/root/.local/share/reth/mainnet/db"
2023-09-21T16:55:49.414871Z  INFO reth::cli: Database opened
2023-09-21T16:55:49.414887Z  INFO reth::cli: Starting metrics endpoint addr=0.0.0.0:9001
2023-09-21T16:55:49.505555Z  INFO reth::cli: Pre-merge hard forks (block based):
- Frontier                         @0
- Homestead                        @1150000
- Dao                              @1920000
- Tangerine                        @2463000
- SpuriousDragon                   @2675000
- Byzantium                        @4370000
- Constantinople                   @7280000
- Petersburg                       @7280000
- Istanbul                         @9069000
- MuirGlacier                      @9200000
- Berlin                           @12244000
- London                           @12965000
- ArrowGlacier                     @13773000
- GrayGlacier                      @15050000
Merge hard forks:
- Paris                            @58750000000000000000000 (network is not known to be merged)

Post-merge hard forks (timestamp based):
- Shanghai                         @1681338455

2023-09-21T16:55:49.609259Z  INFO reth::cli: Transaction pool initialized
2023-09-21T16:55:49.609451Z  INFO reth::cli: Connecting to P2P network
2023-09-21T16:55:49.615779Z  INFO reth::cli: Connected to P2P network peer_id=0x2e6d…1ceb local_addr=0.0.0.0:30303
2023-09-21T16:55:49.620386Z  INFO reth::cli: Consensus engine initialized
2023-09-21T16:55:49.620830Z  INFO reth::cli: Engine API handler initialized
2023-09-21T16:55:49.621988Z  INFO reth::cli: Status connected_peers=0 latest_block=0
2023-09-21T16:55:49.622927Z  INFO reth::cli: RPC IPC server started url=/tmp/reth.ipc
2023-09-21T16:55:49.622933Z  INFO reth::cli: RPC HTTP server started url=0.0.0.0:8545
2023-09-21T16:55:49.622991Z  INFO reth::cli: RPC auth server started url=0.0.0.0:8551
2023-09-21T16:55:49.623002Z  INFO reth::cli: Starting consensus engine

[0xprames]

i can open a PR rq to remove it though (you can too if you fork this repo and open a PR! @idatsy) - but i see what you're saying.

that flag was removed here

[0xprames]

ah i see i may be running with the ghcr version and not a local build - let me try building locally and using compose.

I think thats how to repro