Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump revm to latest main #4135

Closed
wants to merge 1 commit into from

Conversation

DaniPopes
Copy link
Member

Required for Alloy migration, see #3939, bluealloy/revm#535

@onbjerg onbjerg added the A-dependencies Pull requests or issues that are about dependencies label Aug 9, 2023
@@ -495,7 +495,7 @@ pub fn commit_state_changes<DB>(
}
};

cached_account.account_state = if account.storage_cleared {
cached_account.account_state = if account.is_created() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #4135 (ce339f4) into main (24def95) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 54.00%.

Impacted file tree graph

Files Changed Coverage Δ
bin/reth/src/init.rs 96.77% <0.00%> (-0.45%) ⬇️
crates/primitives/src/account.rs 86.73% <0.00%> (+5.65%) ⬆️
crates/revm/revm-inspectors/src/access_list.rs 52.45% <ø> (-0.77%) ⬇️
...ates/revm/revm-inspectors/src/stack/maybe_owned.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/stack/mod.rs 9.45% <0.00%> (+0.30%) ⬆️
...rates/revm/revm-inspectors/src/tracing/fourbyte.rs 0.00% <ø> (ø)
crates/revm/revm-inspectors/src/tracing/js/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/mod.rs 0.00% <0.00%> (ø)
crates/revm/revm-inspectors/src/tracing/opcount.rs 0.00% <ø> (ø)
crates/revm/revm-primitives/src/env.rs 40.84% <ø> (-0.28%) ⬇️
... and 3 more

... and 12 files with indirect coverage changes

Flag Coverage Δ
integration-tests 16.86% <0.00%> (-0.02%) ⬇️
unit-tests 64.10% <54.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 25.94% <0.00%> (-0.01%) ⬇️
blockchain tree 82.83% <ø> (ø)
pipeline 90.07% <ø> (ø)
storage (db) 74.75% <ø> (ø)
trie 94.71% <ø> (ø)
txpool 47.66% <ø> (ø)
networking 77.69% <ø> (-0.09%) ⬇️
rpc 58.67% <0.00%> (-0.01%) ⬇️
consensus 63.76% <ø> (ø)
revm 32.57% <60.00%> (+0.30%) ⬆️
payload builder 6.57% <ø> (ø)
primitives 87.96% <0.00%> (+0.05%) ⬆️

@DaniPopes
Copy link
Member Author

Closing as duplicate of #3512

@DaniPopes DaniPopes closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants