Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: migrate RLP to alloy-rlp #3939

Closed
wants to merge 2 commits into from
Closed

feat: migrate RLP to alloy-rlp #3939

wants to merge 2 commits into from

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Jul 26, 2023 •
edited
Loading

Opening so I don't forget later

Needs bluealloy/revm#535 and subsequent migration, then drop tmp commit

@mattsse mattsse added C-enhancement New feature or request C-debt Refactor of code section that is hard to understand or maintain labels Jul 27, 2023
@DaniPopes DaniPopes force-pushed the alloy-rlp branch 4 times, most recently from a833923 to 9d8dc1f Compare July 27, 2023 21:54
@DaniPopes DaniPopes mentioned this pull request Jul 27, 2023
Closed
1 task
@DaniPopes DaniPopes force-pushed the alloy-rlp branch 4 times, most recently from adcebd4 to 1805c21 Compare August 3, 2023 14:37
@DaniPopes DaniPopes mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions bot added S-stale This issue/PR is stale and will close with no further activity and removed S-stale This issue/PR is stale and will close with no further activity labels Aug 24, 2023
This was referenced Sep 21, 2023
Closed
Merged
@DaniPopes
Copy link
Member Author

This is very hard to rebase at this point so I just rewrote it by basing it on #4737; this also remove most of the ugly hacks

Superseded by #4749

@DaniPopes DaniPopes closed this Sep 23, 2023
@DaniPopes DaniPopes deleted the alloy-rlp branch September 23, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk will be requested when the pull request is marked ready for review rkrasiuk is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected will be requested when the pull request is marked ready for review Rjected is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin will be requested when the pull request is marked ready for review shekhirin is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse will be requested when the pull request is marked ready for review mattsse is a code owner

@rakita rakita Awaiting requested review from rakita rakita will be requested when the pull request is marked ready for review rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo will be requested when the pull request is marked ready for review joshieDo is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg will be requested when the pull request is marked ready for review onbjerg is a code owner

@emhane emhane Awaiting requested review from emhane emhane will be requested when the pull request is marked ready for review emhane is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst will be requested when the pull request is marked ready for review gakonst is a code owner

Assignees
No one assigned
Labels
C-debt Refactor of code section that is hard to understand or maintain C-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse