Skip to content

Add common DOM Functions #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2016
Merged

Add common DOM Functions #313

merged 1 commit into from
Feb 22, 2016

Conversation

simono
Copy link
Contributor

@simono simono commented Oct 6, 2015

getElementById, getElementsByClassName, querySelector and querySelectorAll are often used Functions.

Thanks for the help :-)

@davidchambers
Copy link
Collaborator

This also adds querySelector and querySelectorAll. See #312 for the preceding discussion.

LGTM

@simono
Add common DOM Functions
4c983ba 
getElementById, getElementsByClassName, querySelector and
querySelectorAll are often used Functions.
@qstrahl
Copy link
Collaborator

qstrahl commented Feb 22, 2016

Looks good to me too.

qstrahl added a commit that referenced this pull request Feb 22, 2016
@qstrahl
Merge pull request #313 from simono/feature/add-jsDomElemFuncs
dbacf7e 
Add common DOM Functions
@qstrahl qstrahl merged commit dbacf7e into pangloss:develop Feb 22, 2016
@simono simono deleted the feature/add-jsDomElemFuncs branch February 23, 2016 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simono @davidchambers @qstrahl