Skip to content

Add common DOM Functions #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add common DOM Functions #312

wants to merge 1 commit into from

Conversation

simono
Copy link
Contributor

@simono simono commented Oct 6, 2015

getElementById and getElementsByClassName are two often used Functions.

@Delapouite
Copy link
Contributor

Thanks for this addition @simono
But what about other popular functions like querySelector or querySelectorAll… ?

I see two exclusive options here :

  • extract all the DOM / HTML specific syntax to its own companion plugin. By developping it independently, it will be more complete. Also, people working with pure JS on the server side will have a lighter plugin without all the client side mess.
  • be exhaustive and follow the spec, which is quite huge.

@davidchambers
Copy link
Collaborator

extract all the DOM / HTML specific syntax to its own companion plugin

I like this idea.

Although I'm against vim-javascript giving special attention to DOM APIs, since we already do so it would be completely reasonable to accept this patch (though we'd need a new pull request against develop).

getElementById and getElementsByClassName are two often used Functions.
@simono
Copy link
Contributor Author

simono commented Oct 6, 2015

@davidchambers @Delapouite Thanks for the Review. ebc8386 is against develop and I've add querySelector and querySelectorAll.

Adding all DOM Functions this way is indeed tedious…

@davidchambers
Copy link
Collaborator

ebc8386 is against develop and I've add querySelector and querySelectorAll.

Great. GitHub doesn't let one change a pull request's source or destination branch, so you'll need to open a new pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants