Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Fix armv7 build #59906

Merged
merged 5 commits into from
Sep 30, 2024
Merged

BLD: Fix armv7 build #59906

merged 5 commits into from
Sep 30, 2024

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Sep 27, 2024

@cdce8p cdce8p requested a review from WillAyd as a code owner September 27, 2024 01:38
#define PY_SSIZE_T_CLEAN
// clang-format off
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can remove these clang-format comments now too (I assume they were flagging the multiple includes of the header)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. clang-format changes the order of imports here, so without the comment the change would be reverted by pre-commit.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK...that makes sense. Thanks.

I see CI is broken now but I believe that's unrelated

@rhshadrach
Copy link
Member

CI should be fixed - merge main to kickoff the builds.

@mroeschke mroeschke requested a review from WillAyd September 30, 2024 16:09
@mroeschke mroeschke added ARM aarch64 architecture Build Library building on various platforms labels Sep 30, 2024
@WillAyd WillAyd merged commit cf48036 into pandas-dev:main Sep 30, 2024
97 checks passed
@WillAyd
Copy link
Member

WillAyd commented Sep 30, 2024

Great thanks for the contribution @cdce8p

If you are interesting in further contributions, it might be a nice follow up to check all of the files we have and make sure that the Python include / macro always comes first. Probably worth turning off the clang-format feature that reorders includes to ensure that

@cdce8p cdce8p deleted the fix-armv7-build branch September 30, 2024 20:48
@cdce8p
Copy link
Contributor Author

cdce8p commented Sep 30, 2024

Great thanks for the contribution @cdce8p

If you are interesting in further contributions, it might be a nice follow up to check all of the files we have and make sure that the Python include / macro always comes first. Probably worth turning off the clang-format feature that reorders includes to ensure that

I might be able to take a look at that. No promises though 😅

@WillAyd What is the process to get this fix backproted to 2.2.x / 2.3.x? Should I open a new PR targeting the corresponding branches? Tbh this is currently one of the blocking items adopting the new release and subsequently being reading for Python 3.13.

@cdce8p cdce8p mentioned this pull request Oct 1, 2024
@WillAyd
Copy link
Member

WillAyd commented Oct 1, 2024

So the scope of this is that it prevents running pandas on 3.13 on musl platforms right?

The 2.2 branch I think is closed at this point. We are in the process of backporting a ton of things to 2.3, but I think also want to be very cognizant of what else goes there, because we have already spent a ton of time on that with very limited resources.

@lithomas1 @jorisvandenbossche @rhshadrach might also have opinions

@cdce8p
Copy link
Contributor Author

cdce8p commented Oct 1, 2024

So the scope of this is that it prevents running pandas on 3.13 on musl platforms right?

It prevent building pandas >=2.2.0 on musl with I believe all Python versions. I did the tests with 3.12 but the last working release 2.1.4 isn't compatible with 3.13 in the first place.

@jorisvandenbossche
Copy link
Member

Given that this is a tiny diff, lets at least backport this to 2.3.x

@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 2, 2024
@jorisvandenbossche
Copy link
Member

@meeseeksdev backport to 2.3.x

@jorisvandenbossche
Copy link
Member

It prevent building pandas >=2.2.0 on musl with I believe all Python versions.

If that is the case, would it be good to add a note about this in the 2.3.0 whatsnew file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARM aarch64 architecture Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUILD: Install regression on armv7
5 participants