Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy to 2.1.2 and pandas to 2.2.3 #129958

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Nov 6, 2024

Proposed change

This was previously blocked the musl wheels for pandas 2.2.3 see #108509.

A simple fix has since been merged upstream pandas-dev/pandas#59906. However, it's not clear when the next release will happen. To unblock pandas for 3.13, I applied the patch manually to 2.2.3 and build 2.2.3.post1 for the failing musl platforms. Those wheels are now available on https://wheels.home-assistant.io/musllinux/
An example wheel build is green now: https://github.com/home-assistant/core/actions/runs/11704644949

cdce8p/pandas@v2.2.3...v2.2.3.post1

https://pandas.pydata.org/docs/whatsnew/index.html#version-2-2
https://numpy.org/doc/stable/release/2.1.0-notes.html

Ref: #129442

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2024

Hey there @Petro31, mind taking a look at this pull request as it has been labeled with an integration (compensation) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of compensation can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign compensation Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2024

Hey there @bachya, mind taking a look at this pull request as it has been labeled with an integration (iqvia) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of iqvia can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign iqvia Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2024

Hey there @jpbede, mind taking a look at this pull request as it has been labeled with an integration (trend) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of trend can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign trend Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@home-assistant
Copy link

home-assistant bot commented Nov 6, 2024

Hey there @hunterjm, @uvjustin, @allenporter, mind taking a look at this pull request as it has been labeled with an integration (stream) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of stream can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign stream Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@@ -112,7 +112,8 @@ httpcore==1.0.5
hyperframe>=5.2.0

# Ensure we run compatible with musllinux build env
numpy==1.26.4
numpy==2.1.2
pandas~=2.2.3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the ~= here which allows both 2.2.3 and 2.2.3.post1.

@cdce8p cdce8p mentioned this pull request Nov 6, 2024
44 tasks
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cdce8p 👍

../Frenck

@frenck frenck merged commit 56212c6 into dev Nov 7, 2024
57 checks passed
@frenck frenck deleted the update-numpy-and-pandas-2.2.3 branch November 7, 2024 07:24
frenck added a commit that referenced this pull request Nov 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants