DEP: remove python-snappy and brotli as optional dependencies (no longer used) #54633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
changed the title
lithomas1
approved these changes
Aug 19, 2023
|
thanks @jorisvandenbossche |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 19, 2023
… optional dependencies (no longer used)
3 tasks
raydouglass
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Feb 28, 2024
Previously `python-snappy` was a test dependency. It does not appear that we rely on this directly, as there are no instances of `import snappy`. Recently, pandas also dropped this dependency: pandas-dev/pandas#54633 More generally, we can refactor the dependency list to use `pandas[all]` now that we require pandas 2. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Vyas Ramasubramani (https://github.com/vyasr) - GALI PREM SAGAR (https://github.com/galipremsagar) - Ray Douglass (https://github.com/raydouglass)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32417 (comment) for context.
The
python-snappyandbrotlipackages were in the past a dependency of fastparquet, but that is no longer the case (dask/fastparquet@2e65722, replaced bycramjamthat provides both compression options).I am not sure if there was another reason that we included this in our optional dependencies, but I didn't find any other usage in our codebase.
Closes #32417