Drop python-snappy from dependencies. #15161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
KyleFromNVIDIA
approved these changes
Feb 27, 2024
bdice
added
improvement
|
See #14344 for what happened with python-snappy. |
vyasr
approved these changes
Feb 27, 2024
| "xlsxwriter", | ||
| "xlwt", | ||
| "zstandard", | ||
| "pandas[all]", |
There was a problem hiding this comment.
Was planning to do it. Thank you!
galipremsagar
approved these changes
Feb 28, 2024
|
/merge |
raydouglass
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously
python-snappywas a test dependency. It does not appear that we rely on this directly, as there are no instances ofimport snappy. Recently, pandas also dropped this dependency: pandas-dev/pandas#54633More generally, we can refactor the dependency list to use
pandas[all]now that we require pandas 2.Checklist