STYLE: Enable Pylint useless-parent-delegation warning #49773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s overriding methods
uzzell
commented
Nov 18, 2022
uzzell
commented
Nov 18, 2022
Remove @skip_nested annotations that cause test failures and replace them with statements that suppress the useless-parent-delegation warning.
mroeschke
reviewed
Nov 18, 2022
mroeschke
reviewed
Nov 18, 2022
Member
|
you'll need to run the pre-commit checks too, see the contributing guide for how to do this |
mliu08
pushed a commit
to mliu08/pandas
that referenced
this pull request
Nov 27, 2022
) * Enable Pylint useless-parent-delegation warning and remove superfluous overriding methods * Remove annotations that caused errors. Remove @skip_nested annotations that cause test failures and replace them with statements that suppress the useless-parent-delegation warning. * Remove tests that can fall back to the base class * Move a comment to ensure that pre-commit passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated with #48855. Enables the Pylint type "W" warning
useless-parent-delegation.I have questions about the changes that I made to
test_decimal.pyandtest_numpy.py. I'll elaborate in comments below.