STYLE fix pylint issues

[MarcoGorelli]

In https://github.com/pandas-dev/pandas/pull/48759/files we're introduced pylint, but have turned off its warnings as there's a lot of them:

pandas/pyproject.toml

Lines 36 to 67 in d719840

	disable = [
	"C",
	"R",
	"W",
	"abstract-class-instantiated",
	"access-member-before-definition",
	"bad-super-call",
	"c-extension-no-member",
	"function-redefined",
	"import-error",
	"inherit-non-class",
	"invalid-repr-returned",
	"invalid-unary-operand-type",
	"misplaced-bare-raise",
	"no-member",
	"no-method-argument",
	"no-name-in-module",
	"no-self-argument",
	"no-value-for-parameter",
	"non-iterator-returned",
	"not-an-iterable",
	"not-callable",
	"redundant-keyword-arg",
	"too-many-function-args",
	"undefined-variable",
	"unexpected-keyword-arg",
	"unpacking-non-sequence",
	"unsubscriptable-object",
	"unsupported-assignment-operation",
	"unsupported-membership-test",
	"used-before-assignment",
	]

Task here is:

1. pick one of the above warnings / errors, and remove it from pyproject.toml
2. run pre-commit run pylint --hook-stage manual --all-files. If this already passes, skip to step 4.
3. fixup any warnings that result
4. if pre-commit run pylint --hook-stage manual --all-files passes, then stage and commit your changes and open a pull request

If you believe a warning is a false-positive, then it's OK to ignore it in-line, e.g.

df.rename(id, mapper=id)  # pylint: disable=redundant-keyword-arg

Please comment here which pylint warning you'll work on before starting so we don't duplicate work. No need to ask for permission to work on this, and no need to comment "take" as multiple people can work on this concurrently

---

NOTE: please do not write "closes #48855" in your PR

---

checks we probably can't turn off:

• too-many-function-args
• unsubscriptable-object
• unsupported-assignment-operation
• no-name-in-module
• no-member
• import-error
• not-an-iterable
• invalid-unary-operator-type
• invalid-name
• wrong-import-order (and anything else related with imports)
• unexpected-keyword-argument
• use-implicit-booleaness-not-len
• use-implicit-booleaness-not-comparison
• comparison-with-itself
• no-else-*
• line-too-long
• overridden-final-method
• singleton-comparison
• unsupported-membership-test
• pointless-statement
• broad-except
• undefined-variable

If you're not sure whether a check should fit into the above list, please do ask

[shivamurali]

Hi there! I'll get to work on the "used-before-assignment" warning and remove it from the pyproject.toml file.

EDIT: PR went stale, anyone else is welcome to work on this

[Exoutia]

Hi i am new to open source and i want to contribute to this project by fixing this but i cant seem to run pylint with --all-files option am i doing something wrong.
or do i need to do something before hand beside making a branch and cloning the repo, can someone help me

[MarcoGorelli]

Hi @Exoutia - please show your output

The command is pre-commit run pylint --all-files

[Exoutia]

Hi @Exoutia - please show your output

The command is pre-commit run pylint --all-files

Thanks, now it ran some problems has happened during installation of pre-commit i again installed it and it got fixed

[slackline]

I'll work on removing import-error.

[gulyapulya]

Hi! I am also new to the open source, but I want to contribute, I will work on the "no-method-argument".

[kostyafarber]

Hi! I'll work on inherit-non-class.

[soumilbaldota]

Hi, I will take bad-super-call warning, I have added the pull request above.

[FloHofstetter]

Hi, I will take function-redefined warning.