Skip to content

Conversation

@jbrockmendel
Copy link
Member

Started with sharing some code, unearthed a bug along the way.

Nothing user-facing since it is only in ArrayManager.

@jreback jreback added Bug Dtype Conversions Unexpected or buggy dtype conversions labels Mar 17, 2021
@jreback jreback added this to the 1.3 milestone Mar 17, 2021
@jreback
Copy link
Contributor

jreback commented Mar 17, 2021

is this user facing at all? if so, pls add a whatnew

@jbrockmendel
Copy link
Member Author

is this user facing at all? if so, pls add a whatnew

nothing changing for users. only change is in ArrayManager, where the current behavior doesnt match BlockManager

@jreback
Copy link
Contributor

jreback commented Mar 23, 2021

looks fine, pls rebase and ping on green.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit 1f16f49 into pandas-dev:master Mar 23, 2021
@jbrockmendel jbrockmendel deleted the ref-share-2 branch March 23, 2021 23:10
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Dtype Conversions Unexpected or buggy dtype conversions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants