REF: back DatetimeBlock, TimedeltaBlock by DTA/TDA #40456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Internals
Member
Author
|
rebased + green. between this and #40477 we're within striking distance of ripping out a couple more Block subclasses |
This was referenced Mar 24, 2021
jreback
requested changes
Mar 26, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
this looks pretty good, just a small comment
jreback
reviewed
Mar 29, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
just a question. what's failing on master?
|
|
||
| def blk_func(values, axis=1): | ||
| if isinstance(values, ExtensionArray): | ||
| if values.ndim == 2: |
Contributor
There was a problem hiding this comment.
isn't this just axis=axis ?
Member
Author
havent looked this morning, but last night it was something td64/dt64-casting related merged into npdev |
jreback
approved these changes
Mar 30, 2021
| limit_area=limit_area, | ||
| ) | ||
|
|
||
| values = maybe_coerce_values(values) |
Contributor
There was a problem hiding this comment.
prob can have maybe_coerce_values do downcasting (maybe)
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken off from #40149. Like #40149, this backs DTBlock/TDBlock by (sometimes 2D) DTA/TDA. Unlike #40149, this does not make the DTA backing DatetimeTZBlock sometimes-2D.