Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: F-string formatting in pandas/_libs/*.pyx #29527

Merged
merged 16 commits into from
Nov 11, 2019
Merged

CLN: F-string formatting in pandas/_libs/*.pyx #29527

merged 16 commits into from
Nov 11, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 10, 2019

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@ShaharNaveh ShaharNaveh changed the title F string pyx CLN: F-string formatting in pandas/_libs/*.pyx Nov 10, 2019
@simonjayhawkins simonjayhawkins added the Code Style Code style, linting, code_checks label Nov 10, 2019
@ShaharNaveh
Copy link
Member Author

Super lost,
the tests that failed before are now passing, and the test that passed before are now failing, all I changed was 5 spaces before a string to make pep8 happy.

I have no clue what am I doing wrong.

can anyone help?

@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 10, 2019 21:37
@ShaharNaveh
Copy link
Member Author

ShaharNaveh commented Nov 10, 2019

@jbrockmendel You legend!!!

@jreback jreback added this to the 1.0 milestone Nov 11, 2019
@jreback jreback merged commit 830483d into pandas-dev:master Nov 11, 2019
@jreback
Copy link
Contributor

jreback commented Nov 11, 2019

thanks @MomIsBestFriend

if you can make a master issue for this; would like to do the entire codebase but in multiple PRs, then add a check that we don't regress these changes.

keechongtan added a commit to keechongtan/pandas that referenced this pull request Nov 11, 2019
…ndexing-1row-df

* upstream/master: (109 commits)
  stronger typing in libreduction (pandas-dev#29502)
  API: rename labels to codes (pandas-dev#29509)
  CLN: remove unnecessary type checks (pandas-dev#29517)
  implement _BaseGrouper (pandas-dev#29520)
  CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527)
  Fixed more SS03 errors (pandas-dev#29540)
  consolidate dim checks (pandas-dev#29536)
  REF: separate out _get_cython_func_and_vals (pandas-dev#29537)
  remove unnecessary exception (pandas-dev#29538)
  TST:Add test to check single category col returns series with single row slice (pandas-dev#29521)
  Make color validation more forgiving (pandas-dev#29122)
  DOC: update bottleneck repo and documentation urls (pandas-dev#29516)
  TST: add test for df construction from dict with tuples (pandas-dev#29497)
  add test for pd.melt dtypes preservation (pandas-dev#29510)
  updated DataFrame.equals docstring (pandas-dev#29496)
  Resolved merge conflicts (pandas-dev#29506)
  DOC: Improved pandas/compact/__init__.py (pandas-dev#29507)
  DOC: Update performance comparison section of io docs (pandas-dev#28890)
  TST: add test for df.where() with category dtype (pandas-dev#29454)
  DOC: Fix docs on merging categoricals. (pandas-dev#28185)
  ...
yashukla added a commit to yashukla/pandas that referenced this pull request Nov 12, 2019
yashukla added a commit to yashukla/pandas that referenced this pull request Nov 16, 2019
All changes made for melt.py + black pandas formatting.
yashukla added a commit to yashukla/pandas that referenced this pull request Nov 17, 2019
All changes made for reshape.py + black pandas formatting.
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
yashukla added a commit to yashukla/pandas that referenced this pull request Nov 19, 2019
All changes made for pivot.py + black pandas formatting.
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants