REF: rename 'labels' in pd.factorize to 'codes' #29509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
changed the title
topper-123
force-pushed
the
labels_to_codes
branch
from
e1e850f to
d90c8db
Compare
topper-123
force-pushed
the
labels_to_codes
branch
from
d90c8db to
2f50cd6
Compare
topper-123
changed the title
WillAyd
reviewed
Nov 9, 2019
| # Implementation notes: This method is responsible for 3 things | ||
| # 1.) coercing data to array-like (ndarray, Index, extension array) | ||
| # 2.) factorizing labels and uniques | ||
| # 3.) Maybe boxing the output in an Index | ||
| # 2.) factorizing codes and uniques |
There was a problem hiding this comment.
I think this should remain labels
There was a problem hiding this comment.
We're factorizing the values into codes and uniques, so should be codes?
Maybe the sentence should actually be worded as "2) factorizing values into codes and uniques" (more explicit?
There was a problem hiding this comment.
codes is correct; we are changing on purpose to conform with other usages in the codebase
jreback
approved these changes
Nov 11, 2019
| # Implementation notes: This method is responsible for 3 things | ||
| # 1.) coercing data to array-like (ndarray, Index, extension array) | ||
| # 2.) factorizing labels and uniques | ||
| # 3.) Maybe boxing the output in an Index | ||
| # 2.) factorizing codes and uniques |
There was a problem hiding this comment.
codes is correct; we are changing on purpose to conform with other usages in the codebase
|
thanks @topper-123 |
keechongtan
added a commit
to keechongtan/pandas
that referenced
this pull request
Nov 11, 2019
…ndexing-1row-df * upstream/master: (109 commits) stronger typing in libreduction (pandas-dev#29502) API: rename labels to codes (pandas-dev#29509) CLN: remove unnecessary type checks (pandas-dev#29517) implement _BaseGrouper (pandas-dev#29520) CLN: F-string formatting in pandas/_libs/*.pyx (pandas-dev#29527) Fixed more SS03 errors (pandas-dev#29540) consolidate dim checks (pandas-dev#29536) REF: separate out _get_cython_func_and_vals (pandas-dev#29537) remove unnecessary exception (pandas-dev#29538) TST:Add test to check single category col returns series with single row slice (pandas-dev#29521) Make color validation more forgiving (pandas-dev#29122) DOC: update bottleneck repo and documentation urls (pandas-dev#29516) TST: add test for df construction from dict with tuples (pandas-dev#29497) add test for pd.melt dtypes preservation (pandas-dev#29510) updated DataFrame.equals docstring (pandas-dev#29496) Resolved merge conflicts (pandas-dev#29506) DOC: Improved pandas/compact/__init__.py (pandas-dev#29507) DOC: Update performance comparison section of io docs (pandas-dev#28890) TST: add test for df.where() with category dtype (pandas-dev#29454) DOC: Fix docs on merging categoricals. (pandas-dev#28185) ...
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
factorizeand related stuff, renamelabelstocodes. Also add type hints tofactorize.This is an internal name change, so is ok from an API stability perspective