Convert to monorepo, split into 3 packages #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build fixesPreview: documentation |
Fix tests, update snapshotsPreview: documentation |
Update docsPreview: documentation |
dedupe lockfilePreview: documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@documentalist/compilerruns in Node (target: es2015) and compiles the data@documentalist/clientruns in the browser (target: es5) and contains interfaces/functions/typeguards for rendering the data❓ Why ❓
Previously, this repo had code meant to run in two separate environments distributed together in one package,
documentalist.Users who wanted to reference documentalist types and helper functions for rendering documentation in a browser using JS had to import these symbols from a submodule like
"documentalist/dist/client"(see example in@blueprintjs/docs-themesource)In #81, documentalist switched to emitting es2015 JS syntax, which is supported in all the Node.js versions we care about, but has some unsupported features (arrow functions) in commonly supported browsers (like IE11). The JS emitted in
"documentalist/dist/client"stopped working in IE11.This PR fixes the problem by splitting up the the TS source for the different runtime environments (Node and browser) and creating separate
tsconfig.jsonprojects for each.