Upgrade typedoc and TypeScript for TypeScript 3.2 support #81
Conversation
styu
changed the title
styu
changed the title
Upgrade typescript as wellPreview: docs |
Update test snapshotsPreview: docs |
| @@ -20,7 +20,7 @@ | |||
| "outDir": "dist/", | |||
| "sourceMap": false, | |||
| "strictNullChecks": true, | |||
| "target": "es5" | |||
| "target": "es2015" | |||
There was a problem hiding this comment.
I doubt this will work... AFAIK some es2015 syntax features emitted by tsc are still unsupported in the versions of Node where documentalist runs. I'll double check that this is still the case... if it is, I think another transpilation step is required (and we might ask them to revert the break).
for reference, this is the reasoning they provided for the change:
I changed the tsconfig target from es5 to es2015. This change was made in order to make the ReflectionFlags class act as a class. Since the lib property already includes es2015 libraries, and we only test on node 6+, I believe this is a justifiable change.
There was a problem hiding this comment.
Ok, let me know how/if I should test that or what I can do
There was a problem hiding this comment.
actually, it looks like all non-deprecated versions of Node 6.5+ support the ES features used here. neat! we should probably make a mention in the "engines" block of package.json, but otherwise g2g
There was a problem hiding this comment.
the exceptions I was thinking of all had to do with the ES module syntax, which is not widely supported in Node yet
There was a problem hiding this comment.
actually this ended up causing a blueprint bug. filed #84, i'm looking into fixing it
Release notes
Had to change the target as suggested by typedoc to
es2015, not sure how that will affect downstream consumers