Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minimal button group divider modifier-independent #911

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Make minimal button group divider modifier-independent #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1fc507
Make minimal button group divider modifier-independent
Mar 30, 2017
3d6ecc0
Merge remote-tracking branch 'origin/master' into al/button-minimal-l…
Mar 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/core/src/components/button/_button-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,8 @@ Styleguide components.button-group.css
@include pt-button-minimal-divider();
display: inline-block;
position: absolute;
top: 0;
top: 10%;
bottom: 10%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why percentage instead of pixel offset? i'd expect top/bottom: $pt-grid-size to look good in these cases.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, this becomes too small in the non large use case. Percentage works and is adapting its height no matter the button size

left: 100%;
content: "";
}
Expand Down Expand Up @@ -268,6 +269,7 @@ Styleguide components.button-group.css
&::after {
top: 100%;
right: 0;
bottom: auto;
left: 0;
width: auto;
height: $minimal-button-divider-width;
Expand Down
1 change: 0 additions & 1 deletion packages/core/src/components/button/_common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@ $button-intents: (
margin: ($pt-button-height - $divider-height) / 2;
background: $pt-divider-black;
width: $minimal-button-divider-width;
height: $divider-height;

.pt-dark & {
background: $pt-dark-divider-white;
Expand Down